Giter VIP home page Giter VIP logo

Comments (9)

JoyceBabu avatar JoyceBabu commented on July 16, 2024 1

I tried with building the polyfill with webpack 2, as per advice at webpack/webpack#4743

The issue is fixed and no longer required with Webpack 2.

I would like to create a PR to https://github.com/Financial-Times/polyfill-service for updating the polyfill. Do you plan to upgrade to webpack 2 or continue with the temporary fix? Should I wait or go ahead and create the PR?

from yaku.

ysmood avatar ysmood commented on July 16, 2024

I think this may be a bug of webpack, not Yaku?

from yaku.

JoyceBabu avatar JoyceBabu commented on July 16, 2024

@ysmood I believe it is actually a bug with UC Browser, as all other browsers are working correctly.

I have opened an issue with webpack webpack/webpack#4743

Since Yaku is bundled as the default polyfill in polyfill.io, the service is currently broken for UC Browser users. According to StatsCounter, UC Browser has a global browser market share of 8.75%. According to some reports, in India it is as high as 50%. 28% of our traffic is from UC Browser.

Until it is fixed in webpack, can you please add a work around? (global||{}).Promise would look ugly, but would greatly increase the browser compability of the polyfill.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

(global||{}).Promise added, and new version was published, good luck.

from yaku.

JoyceBabu avatar JoyceBabu commented on July 16, 2024

Thank you. It is now working on UC Browser.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

Thanks for your feedback.

from yaku.

JoyceBabu avatar JoyceBabu commented on July 16, 2024

@ysmood Do you have plans to update to WebPack 2? If not, shall I create the PR for https://github.com/Financial-Times/polyfill-service?

from yaku.

ysmood avatar ysmood commented on July 16, 2024

851df7f

Updated and new version published.

If you have any problem, please let me know.

from yaku.

JoyceBabu avatar JoyceBabu commented on July 16, 2024

The updated plugin is working correctly on UC Browser. Thank you.

from yaku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.