Debug hooks about gopher-lua HOT 4 CLOSED

Hi.
Currently, Go is not suitable for implementing fast scripting language for some reasons.
Debug hooks can easily be implemented in GopherLua, but cause a little performance degradation and are not quite so common(Sandboxing is one of the few exceptions).
Even if debug hooks are implemented as an option, it will need extra 'if' statements in heavy paths on the VM.
So I omitted it to improve performance for common users who do not need debug hooks.

from gopher-lua.

That makes sense to me 👍 . I may fork and add the hooks, just for the project I'm working on. Would you be able to point me in the right direction on where those should be implemented? I'll be diving in some time today to try and get that done, but it will be the first time I've dived in to the gopher-lua source beyond surface level, and some guidance would be a huge help. Feel free to close this issue either way :)

from gopher-lua.

Just off the top of my head...

1. struct LState will hold debug functions as fields.
2. struct LState will hold a counter for counting function calls
3. You will need to check whether interpreter is about to start the execution of a new line of code and execute hook functions near

   gopher-lua/_vm.go

   Line 26 in 3e406ae

   cf.Pc++

   (The line hook)
4. You will need to count instructions and execute hook functions near

   gopher-lua/_vm.go

   Line 26 in 3e406ae

   cf.Pc++

   (The count hook)
5. You will need to execute hook functions near

   gopher-lua/_vm.go

   Line 503 in 3e406ae

   func(L *LState, inst uint32, baseframe *callFrame) int { //OP_CALL

   , L531 and L593(The call hook and The return hook)

I hope that it will be helpful for you.

from gopher-lua.

That's a great start, thanks!

from gopher-lua.