thread-safety and convenience of `basePrint` about gopher-lua HOT 6 CLOSED

The above change does not keep the original Lua behaviour though, notably: the space after every item, no new line after the items, and printing to standard error rather than standard out by default.

Also, why does log have to be used? It would probably be better to give LState an io.Writer field and have it initialized to os.Stdout.

from gopher-lua.

Yes, the change linked up there is for my own use.

The original function added a tab after each printed item instead of a space. And this does actually add a newline after the item set.

Giving LState its own io.Writer is certainly an option. Not ideal though. For instance, in my case, I want all output to written to a single log file. Which would mean each LState would get the same file descriptor. This doesn't solve the thread safety issue.

from gopher-lua.

@jteeuwen - That sounds like an issue with your own code, not gopher-lua. You could easily solve this with a mutex + your own print function.

The most suitable option is allowing a custom writer to be assigned per LState.

In your own code you can then add a function to lock and unlock the writer which is assigned.

from gopher-lua.

I use the log package, which already deals with all of this. It was just a suggestion. It's up to yuin to decide what he deems reasonable.

from gopher-lua.

Threadings

First, the LState(including the print function) is not goroutine safe.I would recommend to use one LState per goroutine and communicate between goroutines by using channels.
And if not so, you have to implement a locking mechanism as andrewchambers remarks.

Default outputs

Lua reference manual says about the print function as follows:

Receives any number of arguments, and prints their values to stdout

If you want to print values to anywhere but stdout, use io.write and/or io.output.

Now, therefore, in consideration of the above, I would like to make no changes to GopherLua.

from gopher-lua.

I agree that you should keep with the standard.

from gopher-lua.