SetFromFlat function doesn't work about infogail HOT 2 CLOSED

Hi Sergiy,

Thank you for pointing this out. Would you please let me know the versions of your Python, Tensorflow, and Keras? Specifically, are you using Python 3? The code was working fine using Python 2.7, Tensorflow 0.12.1and Keras 1.2.2, as I've stated in the readme.

To give you more context, I brought the implementation of TRPO from this repo, where the functions of SetFromFlat and linesearch are exactly the same, please see here and here.

If you have concerns with naming in the function linesearch, you can also refer to these implementations, here, here, and here, where people are adopting the same naming practice.

Best,
Yunzhu

from infogail.

Yes, I'm using Python 3. I can't use Python 2.7 because it's too old for other projects, so I didn't try it. So I think you are right about that, and it's not a bug but just a different Python version. Sorry for inconvenience! But anyways, I hope it will help other programmers who want to shift to Python 3.
And I understand that you utilized some other codes, but still you could change names to something more meaningful. It's not a requirement but rather a good suggestion, so for us it would be much easier to understand the code and all that math behind it.
However, apart from the this, I just want to apologize and leave a good feedback on this project. It's a great job you've done!

from infogail.