Giter VIP home page Giter VIP logo

Comments (9)

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024 1

By the way @yydcdut - great you eventually found some time again to enhance your great lib! thousands of end users will be thankful :)

from rxmarkdown.

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024

Maybe kind of a callback in TextView that passes line and charachter or the complete text as string (with x instead of the space character)?

from rxmarkdown.

yydcdut avatar yydcdut commented on June 7, 2024

Hi,
you mean, you want to click the checkbox?

from rxmarkdown.

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024

yeah, right :)

from rxmarkdown.

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024

@yydcdut Great you implemented a callback :)

Just one question: While the checkbox can be checked and unchecked in the user interface now easily, the callback returns always the initial value.

.setOnTodoClickCallback(new OnTodoClickCallback() {//todo or done click callback
    @Override
    public CharSequence onTodoClicked(View view, String line) {
        Log.v("Note", noteContent.getText()); // <-- This always returns - [x] Test
        return noteContent.getText();
    }

Also the String line always returns the initial value.

It would be great, if one could have the complete Text (including the changed checkbox-status) within the callback. Would that be possible?

from rxmarkdown.

yydcdut avatar yydcdut commented on June 7, 2024

Hi stefan,
First of all, the complete Text means all the content text?
Mentioned in README, TextFactory will destroy the integrity of the content text, so the text in TextView is not the same as the original content text user set. So here, what i thought when coding, the parameter line just wanna tell you to change the original content text, not the text in TextView.
Possibly, I can hold the original text content, and return the complete text (including the changed checkbox-status) .
SO, I just want to think more about it.

from rxmarkdown.

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024

Ah, i understand the problem.

Just one more thought: Wasn't it better to give the lineNumber instead of the line text? Maybe there are multiple lines with the same content, so it would ne safer to go by line number?

Let me hear what you think about the topic and what will be your solution :-)

from rxmarkdown.

yydcdut avatar yydcdut commented on June 7, 2024

Hi, can you create another issue for this?

from rxmarkdown.

stefan-niedermann avatar stefan-niedermann commented on June 7, 2024

#48

from rxmarkdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.