Giter VIP home page Giter VIP logo

Comments (3)

BYK avatar BYK commented on August 17, 2024

Good idea but not sure if this is really possible. May be eslint/espree does it. Are you willing to submit a pull request?

from jsxgettext.

andrewcharnley avatar andrewcharnley commented on August 17, 2024

Why's it not possible? Just add e.fileName = filename;

Reason: the api.parse() takes a dataset and doesn't provide the specific item Acorn threw, instead just passing the Acorn error through.

I doubt linters are using Acorn? so potentially they can throw different errors.

from jsxgettext.

BYK avatar BYK commented on August 17, 2024

Well that's true. I was a bit busy so didn't think long on this before replying. I'd much prefer the parser do this itself and Espree may be doing it. I'm already planning to switch to Espree sometime soon since it helps with handling comments so would simplify our code here.

So if you have the time I'd look into switching the parser to Espree instead of adding this try-catch block.

from jsxgettext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.