Comments (3)
@ghgr hello, thank you for further testing. The previous fix was unescaping the URL in an incorrect place which then made it impossible to find the correct URL in HTML to replace. Bill Gates is now getting properly replaced.
from trilium.
Hello, thank you for the detailed report, should be fixed in the next patch release.
from trilium.
Thank you @zadam !
Just a quick heads up, since you're now escaping the url, the function replaceUrl
in notes.js:514
is not matching the original url, and therefore cannot replace the original link with the local one (at api/attachments/...
). That means that the image is downloaded, but not linked in the note.
I tried replacing quotedUrl
with url
but still doesn't work.
In order to replicate:
- Create a new note
- Go to this linkedin profile (doesn't matter which one, let's take Bill Gates as an example): https://www.linkedin.com/in/williamhgates/
- Right click on his profile picture and "Copy Image"
- Paste into Trilium
- The image shows
- Go to "Note Source"
- See that's pointing to the original source, not the local one
api/attachments/...
You can see in the developer console that's making requests to the 3rd party site every time you open the note.
from trilium.
Related Issues (20)
- (Feature request) HOT 1
- Websocket connection to wss: <site> failed: There was a bad response from the server. HOT 1
- (Bug report) Cant install.. node not found HOT 2
- (Bug report) Sometimes slow Response HOT 2
- (Bug report) HOT 9
- How to show a Card-Style url-links in sharing page (Feature request)
- List View: 3 Pane
- Using Web Clipper "Open in Trilium" opens it full screen, hiding my tray icons HOT 1
- (Bug report) Table with left or right alignment and width != 100% makes the next paragraphs displayed on the side of the table
- (Bug report) HOT 1
- (Bug report) TAB only indents entire line; cannot enter tab character.
- Change note title HOT 1
- (Feature request) Enable trilium iframe compatibility
- (Feature request) Relation Map HOT 1
- About the data transfer after updating the software HOT 1
- (Bug report) ERROR when syncing deleted notes. HOT 1
- (Bug report) No port is listerning after upgrade server from 0.60.4 to 0.63.5 HOT 2
- (Feature request) Question: Is it possible to add geolocation to a note in Trilium? HOT 1
- (Bug report) Themes not working properly in server and Windows version (fonts and visibility) HOT 1
- (Feature request) how to add a copy bottion as the picture shows in text code? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trilium.