Support selecting also other layer types, not just markers about leaflet-lasso HOT 9 CLOSED

Changing:

if (layer instanceof L.Marker) {

To:

if (layer instanceof L.Marker || layer instanceof L.CircleMarker) {

Would actually make it for the CircleMarker case.

from leaflet-lasso.

I am also hoping to be able to do this with either Circle or CircleMarker, it seems to be an issue with the getSelectedLayers() function. Within there there is a check to see if the layer is a "Marker" and if so calls

var r = e.toGeoJSON().geometry;
which in turn calls getLatLng().

Simply changing the o.Marker to o.Circle will get it to try the circles, but it fails to convert the layer. I didn't see what was different in the data structure for the Marker vs the Circle that it shouldn't have worked, but it doesn't.

from leaflet-lasso.

The issue could be that GeoJSON doesn't have an official Circle geometry. There is a draft https://github.com/geojson/geojson-spec/wiki/Proposal---Circles-and-Ellipses-Geoms, never implemented yet.

In order to use turf's capabilities, we can convert Leaflet Circle to GeoJSON Polygon using @turf/circle.

from leaflet-lasso.

It would work only for the center point, the plan here is to support also intersecting with the outer circle

from leaflet-lasso.

That's right for Circle layers. But what about CircleMarker layers? Those have radius in pixels, which in my opinion would be equivalent to trying to match the Marker's image silohuette.

from leaflet-lasso.

Unfortunately, Marker image silouhette is also not matched currently. Only real geocoordinates

from leaflet-lasso.

@matonga is there an unminified version of the js that I can do your edit in, to make it select CircleMarker?

from leaflet-lasso.

@matonga no worries I got it to work with the minified js: towards the end of the file:

(function(e){if(e instanceof o.Marker )

becomes:

(function(e){if(e instanceof o.Marker || e instanceof o.CircleMarker )

from leaflet-lasso.

Implemented in 2.0.0

from leaflet-lasso.