Comments (11)
Looks like missing zlib
linking for Linux (worked when I tested without this). Please apply:
diff --git a/src/modules/Modplug/CMakeLists.txt b/src/modules/Modplug/CMakeLists.txt
index e868ee2..2d3eb3e 100644
--- a/src/modules/Modplug/CMakeLists.txt
+++ b/src/modules/Modplug/CMakeLists.txt
@@ -61,10 +61,8 @@ add_library(${PROJECT_NAME} MODULE
${Modplug_SRC}
)
-if(WIN32 OR CMAKE_SYSTEM_NAME STREQUAL "Darwin")
- find_package(ZLIB REQUIRED)
- target_link_libraries(${PROJECT_NAME} ${ZLIB_LIBRARY})
-endif()
+find_package(ZLIB REQUIRED)
+target_link_libraries(${PROJECT_NAME} ${ZLIB_LIBRARY})
if(USE_QT5)
qt5_use_modules(${PROJECT_NAME} Gui Widgets)
If it will help I'll push a patch :)
from qmplay2.
Thank you, the patch is fine but there is similar but another linking error now.
I suppose that issue depends on what libraries Qt was linked with.
cmake2.build.log.txt
from qmplay2.
The problem with OpenGL and ModPlug is in -Wl,--no-undefined
which is used in your build. The best solution I think is to link to OpenGL libraries instead of removing the flag.
from qmplay2.
Or maybe it is better to force-remove -Wl,--no-undefined
from CMake link flags?
As a workaround please apply:
XVideo:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3cd8de2..d49b97a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -142,7 +142,7 @@ option(USE_PULSEAUDIO "Build with PulseAudio module" ${LIBPULSE_FOUND})
add_feature_info(PulseAudio USE_PULSEAUDIO "Build with PulseAudio module")
if(NOT DEFINED USE_XVIDEO)
- pkg_check_modules(LIB_X11_XV x11 xv)
+ pkg_check_modules(LIB_X11_XV x11 xv xext)
endif()
option(USE_XVIDEO "Build with XVideo module" ${LIB_X11_XV_FOUND})
add_feature_info(XVideo USE_XVIDEO "Build with XVideo module")
diff --git a/src/modules/XVideo/CMakeLists.txt b/src/modules/XVideo/CMakeLists.txt
index 92c6cd7..fb8383b 100644
--- a/src/modules/XVideo/CMakeLists.txt
+++ b/src/modules/XVideo/CMakeLists.txt
@@ -28,7 +28,7 @@ set(XVideo_RESOURCES
icon.qrc
)
-pkg_check_modules(LIB_X11_XV x11 xv REQUIRED)
+pkg_check_modules(LIB_X11_XV x11 xv xext REQUIRED)
link_directories(${LIB_X11_XV_LIBRARY_DIRS})
if(USE_QT5)
OpenGL2:
diff --git a/src/modules/OpenGL2/CMakeLists.txt b/src/modules/OpenGL2/CMakeLists.txt
index 8464ce2..0fe2b4a 100644
--- a/src/modules/OpenGL2/CMakeLists.txt
+++ b/src/modules/OpenGL2/CMakeLists.txt
@@ -97,11 +97,13 @@ target_link_libraries(${PROJECT_NAME}
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
find_package(OpenGL REQUIRED)
target_link_libraries(${PROJECT_NAME} ${OPENGL_LIBRARIES})
-elseif(WIN32)
+else()
if(QT_USES_OPENGLES)
target_link_libraries(${PROJECT_NAME} GLESv2)
- else()
+ elseif(WIN32)
target_link_libraries(${PROJECT_NAME} opengl32)
+ else()
+ target_link_libraries(${PROJECT_NAME} GL)
endif()
endif()
from qmplay2.
from qmplay2.
Ok and I'll force-remove this flag from CMake build.
from qmplay2.
from qmplay2.
The first patch is not necessary if you not use the -Wl,--no-undefined
.
from qmplay2.
The patch: f274748 should fix it without doing any modifications, please test it instead of doing any other modification and patches (I want to know if it works and if it doesn't break anything else) :)
from qmplay2.
| vanilla | f274748
just cmake | OK | OK
packaging macro | Fail | *
*: Shared objects files are put into /usr/usr/lib64 not /usr/lib64. Should
I file another report about it?
from qmplay2.
Also 65f826c is needed if there is no additional linker flags.
Should I file another report about it?
Hmm... Yes.
from qmplay2.
Related Issues (20)
- Desktop files needs to be fixed for flatpak HOT 2
- [Question] Friends! How can I display the lyrics when playing a song? HOT 5
- dotting the Is and crossing the Ts ;) HOT 10
- Equalizer presets cannot be switched HOT 8
- App does not launch after updating python to 3.12 HOT 6
- Screen goes to sleep mode after playback ends HOT 8
- YouTube playlist link won't play! HOT 3
- 我感觉QMPlay2在网络处理方面存在问题,有待加强。 HOT 1
- QMplay2/Win11 no longer connects to internet? HOT 25
- No AppImage? HOT 12
- Make RadioBrowser Connection Error Optional HOT 3
- Recording File Name Customization HOT 2
- Improve Recording Status
- HDR function support (ARIB STD-B67) HOT 9
- QMPlay2 24.05.23 compiled successfully on fedora 37 but failed to start HOT 15
- can not open a playurl HOT 4
- Some questions about downloading
- Windows Xp v20.12.16 minor update for youtube-dl HOT 2
- QMPlay2 does not sort playlist correctly...
- Help in selecting Multi files to send to Top or Bottom of very long playlists? Cheers to the developer on the great work on this player.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qmplay2.