(openSUSE 13.1 + Qt5) build error: no match for 'operator>' about qmplay2 HOT 19 CLOSED

openSUSE 13.1 uses old Qt 5.1. You should use Qt4 for QMPlay2, because it is still better. I don't know how QMPlay2 will works in Qt 5.1
But I can fix it :D

from qmplay2.

Please try now with 86ad547

from qmplay2.

Thank you very much! If Qt 5.1 isn't OK build configuration should fail imho.

from qmplay2.

For me Qt 5.5.1 is not OK. I'm waiting for Qt 5.6.
I don't know if 5.1 is OK or not - you must try and compare to Qt 4.8. I don't remember Qt 5.1, but you may expect crashes or slowdowns or that something won't work :D

from qmplay2.

[ 181s] g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIE -DX11_EXTRAS -DQMPlay2_TagEditor -DQT_NO_DEBUG -DQT_X11EXTRAS_LIB -DQT_WIDGETS_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/include -I/usr/lib64/qt5/mkspecs/linux-g++ -I. -I. -I../qmplay2/headers -I/usr/include/taglib -I/usr/include/qt5 -I/usr/include/qt5/QtX11Extras -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtCore -Ibuild/moc -o build/obj/AudioThr.o AudioThr.cpp
[ 182s] VideoThr.cpp: In member function 'void VideoThr::write_slot(const QByteArray&)':
[ 182s] VideoThr.cpp:486:7: error: 'isPlatformX11' is not a member of 'QX11Info'
[ 182s] if ( QX11Info::isPlatformX11() )
[ 182s] ^
[ 182s] g++ -c -pipe -O2 -Wall -W -D_REENTRANT -fPIE -DX11_EXTRAS -DQMPlay2_TagEditor -DQT_NO_DEBUG -DQT_X11EXTRAS_LIB -DQT_WIDGETS_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/include -I/usr/lib64/qt5/mkspecs/linux-g++ -I. -I. -I../qmplay2/headers -I/usr/include/taglib -I/usr/include/qt5 -I/usr/include/qt5/QtX11Extras -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtCore -Ibuild/moc -o build/obj/SettingsWidget.o SettingsWidget.cpp
[ 182s] make[2]: *** [build/obj/VideoThr.o] Error 1
[ 182s] make[2]: *** Waiting for unfinished jobs....
[ 189s] make[2]: Leaving directory /home/abuild/rpmbuild/BUILD/QMPlay2-src-15.12.06/src/gui' [ 189s] make[1]: *** [sub-gui-make_first-ordered] Error 2 [ 189s] make[1]: Leaving directory/home/abuild/rpmbuild/BUILD/QMPlay2-src-15.12.06/src'
[ 189s] make: *** [sub-src-make_first] Error 2
Should I just require Qt >= 5.2 to build?

from qmplay2.

Ok, so it is a bug, I must add additional #ifdef for Qt 5.1
I'll do it later.

from qmplay2.

from qmplay2.

Please try again! (b78da01)

from qmplay2.

Was built now, thank you!

from qmplay2.

Ok, but remember that building with Qt4 provides more stable application!

from qmplay2.

from qmplay2.

Ok :) !
QMPlay2 in openSUSE "multimedia:apps" - is it your package?
I found that ffmpeg from "multimedia:apps" doesn't support AAC decoding - why :D ?

from qmplay2.

from qmplay2.

Ok, but FFmpeg AAC decoder is under LGPL license like Vorbis. Compiling FFmpeg without any flag enables AAC decoder.

Personally I like Vorbis and Opus, but AAC is very popular codec used also by YouTube, so is there any sense to provide FFmpeg without main codecs? Some people without knowledge of licenses will install FFmpeg from "multimedia" repository and there will be no sound e.g. on YouTube...

from qmplay2.

from qmplay2.

So OK, and what about H.264?
I must implement merging audio stream (Opus/Vorbis) with video stream on YouTube and in multimedia repository it will also works OK :D
Thanks for packaging QMPlay2!

from qmplay2.

from qmplay2.

Hi again!
I released new version - bugfixes. I noticed than new QMPlay2 doesn't use libsidplayfp and libgme on openSUSE. You must install devel files for them before compiling. I also created new mime-types for some file types: https://github.com/zaps166/QMPlay2/tree/master/src/gui/Unix , so they can be copied into /usr/share/mime/packages.

from qmplay2.

from qmplay2.