Giter VIP home page Giter VIP logo

Comments (4)

zb3 avatar zb3 commented on June 10, 2024

Hi, thanks for your feedback!

Of course, pieces should be coming down from the middle, I forgot to change that after I've made an option to choose arbitrary field size -> now fixed!

About the rotation - I've seen the current way everywhere, so I've implemented it this way.
I don't know if I understood you correctly, but I think you're talking about this:

1
2 

1 2

2
1

2 1

Am I right?
I've added this as option as suggested - should work, try it :)

from kf.

Efreak avatar Efreak commented on June 10, 2024

Yes, that's what I'm talking about for rotation. Like tetris. I don't play many games of this type, and it seems illogical to me to be rotating it around anything other than the center of mass.

Unfortunately, whatever you've done has broken the game, at least in Chrome. I get this error:
Uncaught TypeError: Cannot read property 'length' of null from Display.js#77

from kf.

zb3 avatar zb3 commented on June 10, 2024

I wasn't able to reproduce, but I've found a case where this line would fail - injected cross domain stylesheets, so I've fixed it for that case.

However, this case would have nothing to do with my changes :O
So could you tell if my fix fixed the issue?

from kf.

Efreak avatar Efreak commented on June 10, 2024

Hmm. Same error. I should note that I'm running Chrome Dev build, not stable/beta (I can't add my own extensions/userscripts in these 👎). I get the same error when I start a game or try to change the board size.

The game does work fine under a week-old firefox nightly (I'm downloading update now, will post if it changes after), however, so perhaps the problem is on my end. And yes, the changes I had requested work fine.

It also works fine using IE 11, though I notice that it pauses slightly after matching 4 blocks, before it continues; Firefox does not.

Unfortunately, the first computer I had used this game on was my laptop, and I no longer have that device. I should have stable versions of chrome/firefox installed as soon as I can figure out how to separate their profiles (and in chrome's case the browser itself as well).

from kf.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.