Giter VIP home page Giter VIP logo

Comments (8)

coelckers avatar coelckers commented on July 18, 2024

Are you sure about that? I just analyzed the original P_DamageMobj from Heretic and cannot find anything in there that would prevent setting the pain state if called with zero damage.

from gzdoom.

Blue-Shadow avatar Blue-Shadow commented on July 18, 2024

So, the current behavior of suffering pain is an original Heretic behavior? If that's the case, then this can be closed.

from gzdoom.

alexey-lysiuk avatar alexey-lysiuk commented on July 18, 2024

Sorry but this is not original behavior.

I checked in DOS Heretic 1.3 and Chocolate Heretic and there was no IMPPAI sound during gargoyles collisions.
Using a000b57 I hear this sound pretty clearly. Compatibility settings have no influence on this.

from gzdoom.

Gaerzi avatar Gaerzi commented on July 18, 2024

Then let's unclose this.

from gzdoom.

alexey-lysiuk avatar alexey-lysiuk commented on July 18, 2024

Played a bit with Choco in debugger. P_DamageMobj() is called but returns right from here. It's definitely

Shouldn't happen

I was wrong. P_DamageMobj() is never called for gargoyle target if it was hit by other gargoyle. It was various decorations or ammo.

I guess it's because of this condition.

from gzdoom.

Gaerzi avatar Gaerzi commented on July 18, 2024

Interesting. That does abort the function before the skullfly check happens, and therefore prevents the collision from doing any damage. Doesn't this mean that gargoyles also cannot hurt disciples?

from gzdoom.

coelckers avatar coelckers commented on July 18, 2024

They have damage 0, so they never hurt anything. Wow, what a pile of garbage...

from gzdoom.

coelckers avatar coelckers commented on July 18, 2024

Original behavior has been restored. Which makes the flag essentially broken again. But considering its overall lack of usefulness that shouldn't matter.

from gzdoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.