Giter VIP home page Giter VIP logo

Comments (3)

FelixS90 avatar FelixS90 commented on June 22, 2024 1

We had path filters initially in PR #6, but we removed them because the respective github workflows were required PR checks (via branch protection rules). E. g. when you make changes to czishrink, a successful czicompress_cmake build is still required to be able to complete a PR targeting main. So it would be required to 'path-filter' also the branch protection rules.

Thanks for your remark. Please refer to "Additional context" above. The workflow will not be skipped - the job will be skipped based on the outcome of https://github.com/dorny/paths-filter, i.e. it works on job/step level. Thus, individual jobs will be marked as skipped, which however makes the check pass/succeed.

from czicompress.

m-ringler avatar m-ringler commented on June 22, 2024

We had path filters initially in PR #6, but we removed them because the respective github workflows were required PR checks (via branch protection rules). E. g. when you make changes to czishrink, a successful czicompress_cmake build is still required to be able to complete a PR targeting main. So it would be required to 'path-filter' also the branch protection rules.

from czicompress.

m-ringler avatar m-ringler commented on June 22, 2024

I've abandoned the PRs #36 and #37. Nobody seems to work on this any more and there is no real urgency => closing the issue.

from czicompress.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.