Giter VIP home page Giter VIP logo

Comments (13)

zenangst avatar zenangst commented on June 23, 2024 1

Interesting observation, I'll take a deep-dive into how we resolve sequences with duplicate keys. Might be a small 🐛 in there somewhere.

I'll do some digging and get back to you.

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024 1

We can add a feature to hide it entirely when it is empty.
I'll add it to the backlog 😎

from keyboardcowboy.

bjrmatos avatar bjrmatos commented on June 23, 2024 1

awesome, thanks for the quick fixes

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

@bjrmatos I recreated your setup and can reproduce the issue.
I'll keep you posted on the progress.

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

@bjrmatos Good news, I think I figure out what is going on and have a fix for the upcoming version.

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

@bjrmatos would you mind taking 3.23.1 for a spin to verify if this is fixed now?
https://github.com/zenangst/KeyboardCowboy/releases/tag/3.23.1

from keyboardcowboy.

bjrmatos avatar bjrmatos commented on June 23, 2024

it is working now, thanks, this is a great improvement for me, I've tried everything to have keyboard chords (like the ones in vscode) working on macOS level, Keyboard Cowboy is the one that does it the best.

from keyboardcowboy.

bjrmatos avatar bjrmatos commented on June 23, 2024

i have a question, if i have "⌥F ⌥F" sequence setup, but only press the first "⌥F", if i don't press any other key, is there a timeout in which i can press the second "⌥F"? during my test i think i get like 7-8s but wanted to confirm. related to this, do you think it is a good idea to show some kind of indicator (as an option) that the sequence has started?

i mean, for example in vscode if you press the first part of a chord/sequence you get this in status bar:

Screenshot 2024-03-15 at 12  03 04@2x

in Cowboy case maybe what works best is some kind of little float message with just the keys pressed, but just wanted to share the idea, just in case you find it useful.

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

@bjrmatos Right now we don't have a timeout, but if you activate a bundle/sequence, you can always tap on the Escape keep to get out of it.

You can enable bundle notifications in the application settings.

image

from keyboardcowboy.

bjrmatos avatar bjrmatos commented on June 23, 2024

Right now we don't have a timeout, but if you activate a bundle/sequence, you can always tap on the Escape keep to get out of it.

great, thanks, that should be enough for me.

You can enable bundle notifications in the application settings.

interesting, i will give it a try, though not a big fan of seeing an empty circle when not having something to show, but let's see i will experiment with it

Screenshot 2024-03-15 at 1  44 42@2x

from keyboardcowboy.

bjrmatos avatar bjrmatos commented on June 23, 2024

We can add a feature to hide it entirely when it is empty.
I'll add it to the backlog 😎

sounds great!!

sorry to spam the github issue, but since we are already talking about the notification, something i want to mention:

https://share.cleanshot.com/ryPGwcnd

in the video i am activating the "testing" user mode with "⌥K ⌥U", however since i have other keyboard sequences with the "Show bundles" notification enabled, the "testing" user mode notification gets hidden, likely just need a bit of reorder so the notifications get stacked or something like that

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

No worries @bjrmatos, I’ll look into it. Don’t be shy to bring this to my attention, the outcome is that we get a better product ❤️

from keyboardcowboy.

zenangst avatar zenangst commented on June 23, 2024

@bjrmatos did a bit of work on this issue now, the tiny dot won't show up in the upcoming version 😎
I'm also looking into properly reseting and hiding the bundle view if any other keystrokes are invoked (or the match is hit).

from keyboardcowboy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.