Giter VIP home page Giter VIP logo

Comments (5)

zenazn avatar zenazn commented on May 14, 2024

I wasn't planning on writing either of those myself, but it should be relatively easy to adopt existing libraries and middleware for Goji—the interfaces are essentially the same as net/http and would only need minor shims if any. Let me know if you run into any difficulties.

I'd also be happy to sponsor a goji-contrib (a la martini-contrib) if that would be useful, but unfortunately I lack the time to single-handedly fill it.

from goji.

elithrar avatar elithrar commented on May 14, 2024

@zakkwylde I'd suggest just using http://www.gorillatoolkit.org/pkg/sessions "as is", or writing some middleware that makes the session available in web.C.Env and calls session.Save after the handler returns. The benefit to using it "as is'" is that you don't have the request overhead of the session where it's not needed, although you can mitigate that by only applying the middleware to a subrouter.

You could also implement your own handler that embeds a session.

from goji.

franknova avatar franknova commented on May 14, 2024

Why the session.Save(r, w) not happened after the h.ServeHTTP(w, r) in the middleware? T.T

package main

import (
    "fmt"
    "github.com/gorilla/sessions"
    "github.com/zenazn/goji"
    "github.com/zenazn/goji/web"
    "net/http"
)

func main() {
    var store = sessions.NewCookieStore([]byte("secret123"))
    goji.Use(func(c *web.C, h http.Handler) http.Handler {
        handler := func(w http.ResponseWriter, r *http.Request) {
            if c.Env == nil {
                c.Env = make(map[string]interface{})
            }
            session, _ := store.Get(r, "goji-session")
            c.Env["session"] = session
            h.ServeHTTP(w, r)
            //why this not save?  T.T
            session.Save(r, w)
        }
        return http.HandlerFunc(handler)
    })
    goji.Get("/", func(c web.C, w http.ResponseWriter, r *http.Request) {
        if session, ok := c.Env["session"].(*sessions.Session); ok {
            if count, ok := session.Values["count"]; !ok {
                session.Values["count"] = 1
            } else {
                session.Values["count"] = count.(int) + 1
            }
            //Now I have to Save it in everytime
            //session.Save(r, w)
            fmt.Fprintf(w, "count %v", session.Values["count"])
        }
    })
    goji.Serve()
}

from goji.

elcct avatar elcct commented on May 14, 2024

Because likely h.ServeHTTP(w, r) has already written content to the response and you can't set cookie header after this happens.

I have done a workaround for this, you can have a look at my project here:

https://github.com/elcct/defaultproject

I am using custom handler that returns string instead of writing it directly to the response, that way I can save session after running a handler and then send that string.

Check method Route:
https://github.com/elcct/defaultproject/blob/master/system/core.go#L93

from goji.

zenazn avatar zenazn commented on May 14, 2024

I'm going to close this issue out since it hasn't seen traffic in a few months.

I've started a "Goji-contrib" organization at https://github.com/goji. There are already a couple community-contributed middlewares, and I'd be delighted to make repositories for those of you looking to write your own—just shoot me an email. There's also a community-maintained list at https://github.com/zenazn/goji/wiki/Third-Party-Libraries that you might find interesting.

from goji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.