Make mux.Use Variadic about goji HOT 3 CLOSED

I'm not really thrilled with this. I think it encourages really long (and not particularly understandable) lines, which is a personal pet peeve.

But perhaps I'm misunderstanding. Could you explain the use case you're trying to solve with this?

(Fun fact: middleware isn't really "inherited" from the parent router—first the parent goes through its middleware stack, and then the child goes through its stack. The child router in this case has no idea what middleware might or might not have come before it)

from goji.

It would ultimately be a convenience method (as above) although I can see the chance for abuse/a > 200 character line! I'm happy for this to be closed given it's solely a style request.

In the case of parent middleware and sub router middleware: this would mean you can't use Insert to re-order middleware beyond the current sub-router, correct? And the same would go for abandoning middleware outside the subrouters' stack?

(not in front of a PC right now so cannot check!)

from goji.

Yeah, I'm not particularly seeing the convenience over many lines of Use's. I'm going to close this if that's okay.

And that's correct. Each Mux is completely independent, and a Mux can't manipulate middleware it doesn't know about. This is pretty much the only way this can possibly work—consider:

a := web.New(); a.Use(something);
b := web.New(); b.Use(somethingElse);
goji.Handle("/a/*", a)
goji.Handle("/b/*", b)
a.Handle("/a/b/*", b)

Now b has two middleware stacks, depending on what path was used to reach it.

from goji.