Giter VIP home page Giter VIP logo

Comments (2)

chalup avatar chalup commented on May 29, 2024

The library uses android.animation package, which was added in API 11.

I'm not going to support API < 14 myself, as I already mentioned in #2 and #8, but you're more than welcome to fork this project and support older API levels.

from android-floating-action-button.

str4d avatar str4d commented on May 29, 2024

I have looked more closely at the code now :)

The only part of your library that actually requires API 11 is FloatingActionsMenu, and that would be fixed by using NineOldAndroids. Would you be open to having pull requests submitted that implement this? I guess this still puts the long-term maintenance burden on you...

Alternatively, would you be open to putting FloatingActionButton and AddFloatingActionButton into a library-base package (or accepting a pull request from me that does)? The only change needed for them to support API < 11 is to not hardcode holo colors (I was going to move this into a colors.xml). This would not affect any current users, because they would depend on your existing library which would then pull in the library base. Users who then want to use FloatingActionsMenu below API 14 could then use a forked library that depends on your library-base but uses NineOldAndroids.

Basically, I am looking at ways to reduce the issues that will occur when trying to keep a fork in sync with your upstream code. I have opened #12 with the colors changes; I can extend it with the library split suggested above if you like the idea (or if not, I will continue with the fork and figure out the minimum differences necessary).

from android-floating-action-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.