Giter VIP home page Giter VIP logo

Comments (5)

chalup avatar chalup commented on June 4, 2024

Hmm, it might actually make more sense to deprecate the colorNormal/colorPressed attributes in favour of backgroundColor attribute which accepts the color state list. Your comments/thoughts on this approach?

from android-floating-action-button.

bobans avatar bobans commented on June 4, 2024

It sounds good. If it is not big requirement it would be nice to have possibility to set also drawable as background.

from android-floating-action-button.

DineshAnandan avatar DineshAnandan commented on June 4, 2024

👍 for backgroundColor attribute. because i can use the ripple effect in L :)

from android-floating-action-button.

chalup avatar chalup commented on June 4, 2024

@bobans I still haven't implement custom background support, but the fab_colorDisabled was added in #100, available since version 1.6.0.

from android-floating-action-button.

dmitry-zaitsev avatar dmitry-zaitsev commented on June 4, 2024

@DineshAnandan can you actually use ripple as color state list? I doubt it.

I would rather deprecate all custom attributes (colorNormal, colorPressed, colorDisabled) and use android:background instead which we can then paint as a circle using BitmapShader. That would allow any kinds of background drawables. Hopefully I'll find the time to make pull request for it :) If not - you have my idea.

from android-floating-action-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.