False-Positive when detecting rails application about racecar HOT 8 CLOSED

In our case (our case = no rails but activesupport/railties) script fails on Rails.logger.extend so kind of ugly hot-fix would be changing

   begin
        require "rails"
      rescue LoadError
        # Not a Rails application.
      end

to

   class OnlyActiveSupportDetected < LoadError; end

   begin
        require "rails"
        raise OnlyActiveSupportDetected if Rails.logger.blank?
      rescue LoadError, OnlyActiveSupportDetected
        # Not a Rails application.
    end

but it's ugly and I don't like it and it can still produce False-Positives (less than before of course, so that's good) but there could be more false-negatives (i.e. Rails apps that have no .logger assigned? Is it possible? I don't know).

from racecar.

Our temporary fix which apparently does not break anything

#kafka_setup.rb

Racecar::RailsConfigFileLoader.class_eval do
  def self.load!
    $stderr.puts "=> Skipping rails detection as monkeypatch in kafka_setup.rb..."
  end
end

and include this file in bundle exec racecar --require kafka_setup.rb

from racecar.

Can you figure out a better way of detecting Rails?

from racecar.

Plus one for a fix on this - using racecar with ActiveRecord and no rails

from racecar.

How about a --no-rails flag that disables Rails booting?

from racecar.

Lets share some friendly knowledge and advise :) why not like that? https://github.com/karafka/karafka/blob/master/lib/karafka/cli/install.rb#L31

from racecar.

If it works! ❤️

Anyone up for doing a PR?

from racecar.

Works really well for "us". Also allows to determine that you have rails in the stack (I don't expect anyone sane to include it and not use it at all) prior to being loaded.

from racecar.