HTTP 500 on /deploys/confirm endpoint after clicking Review about samson HOT 8 CLOSED

so bug seems to be that it could not find the comparison
which I think comes from app/models/changeset.rb:71
which means that there is neither github not gitlab configured ? -> check project.gitlab? and project.github?
... or maybe github failed and there is an error in the logs somewhere ?

from samson.

@grosser #3801 has fixed the issue for us!

I updated app/models/changeset.rb as per the PR and the commit range is now displaying.

Thanks for fixing so quickly!

from samson.

For some context the github integration does appear to be working correctly. I enabled debug logging and see lines like:

get https://api.github.com/repos/******/user-service/commits/172ea909f736866a1ac0eb17655e996035ce6cfd/status
...
server: "GitHub.com"
status: "200 OK"

from samson.

still sounds like a bug then, either the project not knowing that it's github or github request failing ...

from samson.

Our projects are configured with "[email protected]..." URLs:

Is there anything else I could check to help debug?

from samson.

from samson.

I updated changeset.rb with the following:

  def find_comparison
    return NullComparison.new if empty?
    if @project.github?
      Rails.logger.info("github true")
    else
      Rails.logger.info("github false")
    end

The log file showed github true after clicking the review button.

I've had another look over the logs with debug enabled and can't see evidence of Github API requests failing. The Github API responses for calls like /status, /check-suites, /check-runs are all 200 OK.

This is how the UI appears if that helps:

from samson.

sounds like all is good then ... if your comparison is always empty now (even for commits that have changes) we should take another look though

from samson.