Comments (8)
so bug seems to be that it could not find the comparison
which I think comes from app/models/changeset.rb:71
which means that there is neither github not gitlab configured ? -> check project.gitlab?
and project.github?
... or maybe github failed and there is an error in the logs somewhere ?
from samson.
@grosser #3801 has fixed the issue for us!
I updated app/models/changeset.rb
as per the PR and the commit range is now displaying.
Thanks for fixing so quickly!
from samson.
For some context the github integration does appear to be working correctly. I enabled debug logging and see lines like:
get https://api.github.com/repos/******/user-service/commits/172ea909f736866a1ac0eb17655e996035ce6cfd/status
...
server: "GitHub.com"
status: "200 OK"
from samson.
still sounds like a bug then, either the project not knowing that it's github or github request failing ...
from samson.
Our projects are configured with "[email protected]..." URLs:
Is there anything else I could check to help debug?
from samson.
from samson.
I updated changeset.rb
with the following:
def find_comparison
return NullComparison.new if empty?
if @project.github?
Rails.logger.info("github true")
else
Rails.logger.info("github false")
end
The log file showed github true
after clicking the review button.
I've had another look over the logs with debug
enabled and can't see evidence of Github API requests failing. The Github API responses for calls like /status
, /check-suites
, /check-runs
are all 200 OK
.
This is how the UI appears if that helps:
from samson.
sounds like all is good then ... if your comparison is always empty now (even for commits that have changes) we should take another look though
from samson.
Related Issues (20)
- <com.getbase.floatingactionbutton.FloatingActionsMenu HOT 1
- Review button is disabled if git reference not entered quickly enough HOT 3
- Request: documentation for secrets usage HOT 2
- LDAP Authentication fails HOT 2
- Local cache for large repositories HOT 1
- Live demo leaking user info HOT 2
- Can't remove a global lock in v3222 HOT 2
- Trying to deploy while global lock is on causes exceptions HOT 3
- Samson creates release for non-existent commit HOT 1
- Deploy screen no longer showing git file differences after clicking Review HOT 5
- Setting environment variables on a per deploy basis via API HOT 1
- assets:precompile not generate env plugin assets HOT 4
- Losing functionality after moving Github repo across Github organization HOT 7
- docker hub renew
- Project in active development? HOT 1
- Latest releases not published to Docker Hub HOT 3
- Possible Alternative to Samson? HOT 3
- User not able to login again to Samson using Github Id HOT 6
- Security vulnerability HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from samson.