Giter VIP home page Giter VIP logo

Comments (9)

ppaulis avatar ppaulis commented on July 25, 2024 1

https://travis-ci.org/zendframework/zend-cache/jobs/565853773#L1058
Build on PHP 5.6 fails because of this. I'll try to find some time to check this out.

from zend-cache.

michalbundyra avatar michalbundyra commented on July 25, 2024

@gabrovex Would you like provide PR with this change? Thanks!

from zend-cache.

ppaulis avatar ppaulis commented on July 25, 2024

@gabrovex @webimpress This happens since redis extension v5.0.0. As a workaround, you can downgrade to 4.3.0. My PR should fix that behaviour.

from zend-cache.

michalbundyra avatar michalbundyra commented on July 25, 2024

@ppaulis

This happens since redis extension v5.0.0. As a workaround, you can downgrade to 4.3.0.

This is actually very good point. Now just wonder if by this change we are not introducing BC Break. We do not have any requirements on Redis version so I guess we should add. Probably also we would need update tests to run with previous version of Redis (4.x, maybe even 3.x?)

from zend-cache.

ppaulis avatar ppaulis commented on July 25, 2024

@ppaulis

This happens since redis extension v5.0.0. As a workaround, you can downgrade to 4.3.0.

This is actually very good point. Now just wonder if by this change we are not introducing BC Break. We do not have any requirements on Redis version so I guess we should add. Probably also we would need update tests to run with previous version of Redis (4.x, maybe even 3.x?)

@webimpress That's a very good point too. If the tests on all redis-server versions pass (no BC break), a new bugfix release could be made.
If, however, that's not the case, we would need to create a new major version (3.0.0 ?) with a requirement on the redis-server version? I don't see any alternative there, because the redis extension is already released.

from zend-cache.

ppaulis avatar ppaulis commented on July 25, 2024

@webimpress What I currently don't get, is, why the build fails on memcache for PHP 5.6 when I change a few calls in the Redis adapter.

from zend-cache.

michalbundyra avatar michalbundyra commented on July 25, 2024

@ppaulis

why the build fails on memcache for PHP 5.6 when I change a few calls in the Redis adapter

I think because other version of service/extension is now installed. I've checked latest passing build on master and for example I see there Redis 4.0.6, your build uses Redis 5.0.4 (but I guess there could be similar reason?)

from zend-cache.

pimjansen avatar pimjansen commented on July 25, 2024

Any update on this? Its stopping us for using Zend\Cache at this point with the latest PHP version

from zend-cache.

Ocramius avatar Ocramius commented on July 25, 2024

I'd suggest adding a "conflict": {"ext-redis": ">=5.0.0"} for existing versions, and fixing this (by adding "conflict": {"ext-redis": "<4.0.0"} in a new minor.

from zend-cache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.