Comments (6)
Thanks for the well thought out comments @SKRohit. Here are my answers:
- Yes I believe that would be enough.
- Every datasource is connected atleast to a data pipeline, therefore if you delete all pipelines then you will delete all datasources in essence.
- See above - if you delete all pipelines than there should be no datasources left as each datasource produces a data pipeline per commit.
In general, internally we are preparing a big change in the next month that will rewrite a lot of this logic and make things easier. For now, please implement as simple as possible logic that goes through pipelines and deletes their artifact and metadata stores. Please try to decouple functions as after the refactor it might still be useful! Thanks!
from zenml.
Hi, I'd like to work on this issue.
Please help me out with the details.
from zenml.
Thank you @harshasridhar. Thank you for the contribution, it is greatly appreciated!
Here are a few pointers:
When the user uses zenml clean
the following needs to happen.
For each pipeline in the pipeline_store
specified in the zenml_config
, you need to delete the metadata_store
and the artifact_store
. Here is how:
- Deletion of the artifact store [this can be remote or local -> using
path_utils
is important here. This should be simple. - Deletion of the metadata store [this can be remote or local] -> Local its just a sqlite so using
path_utils
works but remote it is a MySQL, in which case a sqlDROP
statement needs to be made on the specific database
Finally, the pipeline_store
needs to be deleted.
For each concept above the docs go into some detail: https://docs.zenml.io . I hope thats good for a starting point but might require more discussions. Please feel free to join the slack to chat directly. Thanks again for your effort!
from zenml.
@htahir1 I am looking into this issue. And this is what I understood and what I have doubts about.
- Every
BasePipeline
object hasmetadata_store
andartifact_store
attributes so deleting those for each pipeline would be enough? - Also, every
BasePipeline
object also hasdatasource
attribute which is aBaseDatasource
object and it has its ownmetadata_store
andartifact_store
should we consider them as well for deletion? In my opinion, I think it should be deleted separately since there is a possibility thatartifact_store
andmetadata_store
of datasources and pipelines could different let me know your thoughts. - Also, should
zenml clean
also delete datasources whaich are not related to any pipeline?
from zenml.
#540 is addressing this now in a simpler way
from zenml.
This issue has been implemented now in #540 so I'm going to close this.
from zenml.
Related Issues (20)
- [BUG]: Connection error between Kubeflow and ZenML HOT 7
- [BUG]: Trying to run `zenml go` in a docker container results in errors
- Runtime Errors, not allowing me to access the pipeline HOT 1
- [BUG]: RuntimeError when using zenml up HOT 1
- [BUG]: K8s orchestrator for scheduled pipeline: AttributeError: 'BatchV1Api' object has no attribute 'create_namespaced_cron_job' HOT 3
- [BUG]: The tags for the AWS Sagemaker orchestrator are passed in the wrong format HOT 4
- [BUG]: Validation Error when trying to deploy a Vertex orchestrator on GCP HOT 2
- Add a security policy HOT 2
- [BUG]: Issue when the "user" parameter is set in DockerSettings HOT 2
- [BUG]: Variable naming for `generative-chat` example HOT 2
- [BUG]: Volumes not accepted as a docker setting HOT 5
- [BUG]: GCS based Artifact Store connected through GCP Service Connector could not provide proper GCP service credential information to Label Studio annotator. HOT 1
- [BUG]: GCS URLs are of the form gs://bucket-name/path/to/file so we only need the path/to/file to match the Label Studio tasks HOT 2
- [BUG]: incorrect documents list given to FAISS function HOT 1
- [BUG]: inconsistent pointers to helm chart ocis HOT 4
- [BUG]: kaniko pod `serviceAccountName` specified in wrong scope
- [BUG]: Error in the Materializer for integration with Langchain >= 0.0.325 HOT 2
- [BUG]: kubernetes orchestrator fails trying to create clusterrolebinding instead of rolebinding
- [BUG]: TypeError: 'StepArtifact' object is not subscriptable
- [BUG]: Config.yaml step config only used in first step when calling step multiple times HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zenml.