Why does forEach throw away the return value while map/filter pass it through unchanged? about es-observable HOT 4 CLOSED

The basic propagation story is that with observables, all completion values (whether normal, throw, or return) are pushed up the call stack, instead of flowing down the stack. Throws propagate up the stack via the observer's "throw" method. If the observer doesn't have an error handler, or itself throws an error, then the exception will propagate back down the stack.

Let's take map with argument fn.

With iterators, map would get the next value from upstream, execute fn on the value, and then yield the result to the caller. If an error occurred getting the value from upstream, or during execution of fn, then that error would propagate down the stack as a thrown exception.

With observables, map would receive the next value from upstream, execute fn on the value, and push the result to the observer. Any errors from upstream will be forwarded (pushed) to the observer. If an error occurs during execution of fn, then we catch that error and attempt to push it to the observer. Since we don't map over the return value, the return value is simply forwarded (pushed) to the observer.

forEach is a little different, in that it cannot be chained any further and errors are propagated with a promise. We (I think) decided in the other thread that it should return Promise<void> instead of Promise<R>, with R being the type of the result value. The intention there is to provide a combinator that allows easy integration with promises in general and await specifically.

Does that help at all?

from es-observable.

A little bit. I'll try to think on it more before replying. The up-then-otherwise-down seems a bit schizophrenic, but maybe after I run through it a few times it'll make more sense.

I still don't think this justifies removing the return value from forEach, unless you also remove the exception. Although, hmm, then what would you do for reduce? I guess that would have to throw away the return value, so maybe it makes sense to say that sequence terminators throw away the return value, but any exceptions "bubble"? (The path along which they bubble seems very strange though... will think on it more.)

from es-observable.

ForEach is meant to approximate For...of behavior which drops return value. Trying to approximate behavior of eventual for...on, to make the refactoring path easy.

Closest example to generators as streams would be itertools on pythons. Will be interesting to examine what they did here. There are also open questions about how to handle return values in merging operations. The two options seem to be to drop the return value, or provide an aggregation function ( a la reduce) to accumulate them somehow.

from es-observable.

forEach is out for now

from es-observable.