👋 Thoughts on pull requesting this into a core fastlane action? about fastlane-plugin-notarize HOT 7 OPEN

Hey @joshdholtz 👋

It’d actually be great. 🙌 We were hoping to integrate this plugin to the core product as this will become mandatory for all non-App Store macOS apps real soon. We actually even tried to add it to the core when we were first building it. 😁

I quickly checked the the contributing file and your first pr documents on the repo. Is there a guide or a format we can follow for adding new actions in addition to these documents?

from fastlane-plugin-notarize.

@yigitcanyurtsever Perfect, this makes me so happy! All you need to do is paste https://github.com/zeplin/fastlane-plugin-notarize/blob/master/lib/fastlane/plugin/notarize/actions/notarize_action.rb into https://github.com/fastlane/fastlane/tree/master/fastlane/lib/fastlane/actions and then open a PR and that should be it!

I can take care of making sure it runs and adding tests and everything once you make the PR 💪

from fastlane-plugin-notarize.

Thank you! I will get that merged in tomorrow and we will probably have a new release out early next week 💪 I tend to not like to do releases before weekends 😇

Best practice would be to add deprecation notes (see this example of the hockey action) - https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/hockey.rb#L393-L402

This will show a deprecation message to the user when running. The message could inform users to remove the plugin from their Pluginfile and that should be pretty good!

from fastlane-plugin-notarize.

Hey @joshdholtz ,

Thanks again for reaching out and working with us on this. 🙌 I’ve released a final version for the plugin with the deprecated notes and updated the README.md.

Not sure if this is the right place but wanted to mention it before I forget: We wanted to add error handling for the sh action calls via error_callback parameter to display the actual result to the users if the action failed but didn’t find the time to do so. We'd be happy to contribute this addition later on but wanted to let you know anyways.

Cheers!

from fastlane-plugin-notarize.

Awesome! 🙌 @berkcebi just opened the PR. 🥳

When the next fastlane version is released, I’m planning to update README file and release one final version for the plugin with a UI message suggesting to use the action on the core product. Does this make sense? Or is there any other common practice for this?

from fastlane-plugin-notarize.

Thanks a lot @joshdholtz! That's the exact thing I was looking for. 🙌 I'll try to prepare the release this week as well.

from fastlane-plugin-notarize.

@yigitcanyurtsever Hey! If you would like to contribute that in that would be 💯 Otherwise feel free to file an issue and one of us will get to it sometime 😊

Thanks again for the code donation! ❤️

from fastlane-plugin-notarize.