zest.releaser doesn't honor SVN files about zest.releaser HOT 13 CLOSED

Ah, already got this one.
The problem here is that the releaser uses the default python in the path, not the one you use to run 'release'.

It can be useful to run "easy_install setuptools" (or upgrade it) to get the version that will honor the files in the SVN directory. "easy_install setuptools-git" can be useful too (when using git).
I've ran a few times in this issue :/

Maurits will have a better answer I think ;)

from zest.releaser.

Maybe abort the process if bad setuptools + VCS combo detected?

from zest.releaser.

Hi Mikko,

How are you?

Thanks for your feedback. I forwarded your mails to the people that work with zest.releaser, because I don't actively program any more ;)

Maurits the maintainer of this package is on vacantion till next wednesday.

Cheers,

Jean-Paul

Verzonden met mijn IPhone, typfouten voorbehouden ;)

On 12 jun. 2012, at 16:09, Mikko Ohtamaa [email protected] wrote:

zest.releases doesn't honour SVN added repository files when creating a package. I think this is the default setuptools behavior. Only .py files are packed. This caused malformed packages which have files left out.

Getting distribution for 'mfabrik.webandmobile'.
error: docs/HISTORY.txt: No such file or directory
An error occured when trying to install mfabrik.webandmobile 1.0.11. Look above this message for any errors that were output by easy_install.
While:
Installing instance.

Subversion 1.7.

---

Reply to this email directly or view it on GitHub:
#10

from zest.releaser.

Jean-Paul, no more Plone? Lucky you :)

Thanks - I'll stay tuned to see what would come for this package.

from zest.releaser.

The very latest version (3.34) should warn you when you're missing a MANIFEST.in file or if you don't have the setuptools-svn package installed.

See 5a390aa, 1e094f4 and 78de350

from zest.releaser.

Hi Mikko,

Well still Plone, but more sales and project management than development ;)

Cheers,

JP

On 12 jun. 2012, at 17:45, Mikko Ohtamaa wrote:

Jean-Paul, no more Plone? Lucky you :)

Thanks - I'll stay tuned to see what would come for this package.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

from zest.releaser.

This issue must be reopened and I don't have a permission to reopen.

It doesn't work even after upgrading setuptools.

from zest.releaser.

The only warning I get is:

This package is missing a MANIFEST.in file. This file is
recommended. See http://docs.python.org/distutils/sourcedist.html for
more info. Sample contents:

from zest.releaser.

Hmm, apparently the warning message is misleading. I think the correct behavior would be

• Warn about missing MANIFEST.in and setuptools_subversion packages
• If neither of them is present abort the release

from zest.releaser.

I just re-opened it for you. Some points:

• Upgrading setuptools won't help: it just doesn't support the new svn format. In a sense that's not zest.releaser's problem.
• It might not be zest.releaser's problem, but we should warn. Which we do. We even print a readily-made MANIFEST.in for you. Perhaps the warning should be more forceful?

I haven't checked if we check for the existence of the setuptools_subversion package. Checking that would be handy.

• I don't think aborting the release is a good idea: there might be other plugins besite setuptools_subversion. It might be a release with only .py files. And so on.

So: I'm leaning to only upgrading the warning at this point. Open for debate. Ok to wait for maurits (the other core dev) to return from his vacation? Should be back in a week or so :-)

from zest.releaser.

Aborting should be done, or at least should have manual confimation "Looks like you are going to build broken egg - do you want to live with the consequences? [Y/n]# As otherwise the likely case is that one ends up with broken eggs on PyPi, gets shitsloads of bad feedback and that's major PITA to clean-up. Rather to be on the safe-side completely.

I know setuptools is a bag of horse manure, but there must be a way to know if the egg what is going to be built is sane or not.

from zest.releaser.

Actually, using a y/N question isn't so bad. Ok, sounds like a plan!

Reinout van Rees
http://reinout.vanrees.org/
(Sent from my iPad, so it is probably short)

Op 20 jun. 2012 om 23:22 heeft Mikko [email protected] het volgende geschreven:

Aborting should be done, or at least should have manual confimation "Looks like you are going to build broken egg - do you want to live with the consequences? [Y/n]# As otherwise the likely case is that one ends up with broken eggs on PyPi, gets shitsloads of bad feedback and that's major PITA to clean-up. Rather to be on the safe-side completely.

I know setuptools is a bag of horse manure, but there must be a way to know if the egg what is going to be built is sane or not.

---

Reply to this email directly or view it on GitHub:
#10 (comment)

from zest.releaser.

Oh, I am already back actually. :-)

We already check for the setuptools_subversion package (or setuptools-git if it is a git repo, etcetera).

The current code already has a commented out question in this spot, as we (or I) deemed it nicer to only print the warning. But indeed, let's try to avoid broken PyPI releases. I have updated the code and running the tests now. I will make a 3.35 release shortly.

from zest.releaser.