Giter VIP home page Giter VIP logo

Comments (5)

reinout avatar reinout commented on July 22, 2024

Well, we could mention it. But I don't regard them as mandatory. The poreleaser is very handy, agreed.

But both setuptools packages are better replaced with a proper MANIFEST.in file.

Maurits? Nice advertising opportunity for zest.poreleaser :-)

from zest.releaser.

miohtama avatar miohtama commented on July 22, 2024

I think better be safe than sorry. You probably don't lose anything having those deps there...?

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

Well, you invite mistakes by others that don't use the buildout. With a MANIFEST.in you're covered.

And: I dislike having unneeded things lying around. It is a bit untidy, imho. So in that sense it is a loss.

But if you (or Maurits) can phrase it as a suggestion or configuration example, it won't really hurt. Could you fork and make the change? That's easier for me to say 'yes' to :-) :-) I'm lazy, which is why I made zest.releaser :-)

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

Well, I have seen setuptools-subversion slow things down because it does an 'svn ls', which needs to talk to the server. So I am not sure if I still have that package installed currently.
And setuptools-bzr should logically also be added, but last time I checked it, it was broken. I don't remember if it could not be installed or if it simply failed when you tried to make a release in a bazaar checkout.
So: -1 on adding these as hard dependencies.
We could add these as an extra_requires in the setup.py and point to this in the readme.

from zest.releaser.

miohtama avatar miohtama commented on July 22, 2024

Closing this, as the discussion has ended

from zest.releaser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.