Giter VIP home page Giter VIP logo

Comments (9)

reinout avatar reinout commented on July 22, 2024

iirc it prints the location of the tag checkout (a temp directory) at the end. I added this to make it easier to re-upload it from that directory. That dir contains a nice clean un-postreleased version of your package.

Pypi down is quite rare nowadays, especially for uploading.

Is aborting the best way? You'd have to know how to proceed from there. Well, you have to know what to do with the tag temp dir, also, of course.

Ideas?

from zest.releaser.

miohtama avatar miohtama commented on July 22, 2024

It's more like you are going to miss the line of text because it is lost in the other logging noise. Thus, it might be that a partial file ends up to pypi.

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

If setup.py has a non-zero return state here, we should be able to pick that up and display a big fat warning.

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

If I call print system(utils.setup_py('My brain hurts')) currently no error is printed. This is because for python commands we do not show the stderr. See https://github.com/zestsoftware/zest.releaser/blob/3.56/zest/releaser/utils.py#L436
Reason is that this may contain warnings or other fluff that is harmful when we try to extract the version number.
I should probably change a few system calls to quit when there is an error, or to ask the user if she wants to continue.

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

I think pull request #90 does this nicely.

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

That pull request is merged to master. Will end up in 4.0 soon.
We are not exactly aborting when upload fails, but we print it in red and ask the user if she wants to continue.

from zest.releaser.

mgedmin avatar mgedmin commented on July 22, 2024

Do you give the user an option to retry?

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

No. Would be interesting. I am playing with it now. :-)

from zest.releaser.

mgedmin avatar mgedmin commented on July 22, 2024

Heh. I just recently ran fullrelease on a package I didn't have PyPI rights on. It worked out okay: when the upload failed and zest.releaser asked if I wanted to bump the version to n+1.dev0, I asked for PyPI rights on IRC instead, dug out the temp directory name from xterm scrollback, twine uploaded the sdist, and then let fullrelease continue.

from zest.releaser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.