Comments (2)
I can see the need you describe. However, I wonder about some corner cases:
- In some cases you want to make a release of some older revision. I guess a "git fetch" won't hurt then.
- The behaviour should be similar for svn/bzr/hg and an "svn up" can hurt harder than a "git fetch".
- Is "origin" reliably always called "origin"?
OTOH, zest.releaser wants to push the changes afterwards, so the branch effectively MUST be up to date.
I guess my worries are mostly no problems in practice. "svn up" is the one I'm worried most about. @mauritsvanrees?
from zest.releaser.
With svn this is unneeded: when running prerelease and trying to commit it, you see the error immediately.
This would only be needed for git and friends, because there you can easily commit your hard work locally and totally forget to check if someone else has done work upstream too.
git fetch
just fetches any extra commits and does not update the working directory, so that sounds safe. BTW, we should probably do git fetch --all
to get all remotes. Whether the remotes are called origin or something else does not matter.
For bzr it should probably be bzr missing --theirs-only
.
For mercurial, hg pull
only gets the changes, without updating the working directory, so that seems safe too.
The most tricky with all these things is probably that we need to parse the output (possibly translated) to see if we need to warn the user. But in case of doubt we can always simply ask, with a default answer of 'No'.
from zest.releaser.
Related Issues (20)
- Check version for PEP440 HOT 3
- bumprelease functionality HOT 6
- zest.releaser with plone.releaser breaks when not in a buildout.coredev environment HOT 3
- Failed git push does not fail release HOT 6
- Possibility to add prefix to commit messages HOT 6
- ValueError: binary mode doesn't take an encoding argument HOT 9
- fullrelease: error: no such option: --no-input HOT 8
- sdist is missing tox.ini HOT 1
- tests fails with non-GNU ls HOT 4
- testing: the following arguments are required: message HOT 1
- testing: bumpversion and postrelease tests fails HOT 3
- Always create wheels, when possible HOT 2
- Warn/ask to verify for deprecation notices when making a major release HOT 4
- get_last_tag can fail with recent setuptools HOT 1
- Use build to generate wheels and sdists HOT 7
- Read zest.releaser settings from pyproject.toml HOT 3
- Issue during our dependency-check analysis because of tests/pyproject.toml file HOT 1
- Upload to PyPI fails HOT 6
- readthedocs documentation isn't being build anymore HOT 2
- Issues when trying 'build' HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zest.releaser.