Giter VIP home page Giter VIP logo

Comments (6)

reinout avatar reinout commented on July 22, 2024

You're right. I'm not building wheels myself (yet), so I don't have experience with them yet.

You're saying that if there's bdist_wheel in the setup.cfg, is it really only a matter of adding the extra bdist_wheel argument to our call to setup.py?

Or can there be more that needs to be done? Like making different kinds of wheels?

I really should dive into wheel usage. I'm pretty certain I'll like them :-)

from zest.releaser.

hgrecco avatar hgrecco commented on July 22, 2024

You can build specific wheels using command line switches (docs) but I think that is ok to ask zest.releaser users to have a properly designed setup.cfg (That is what everybody will do anyway.)

For pure python packages that are compatible with python 2 and 3 I think the suggested approach is valid (Maybe checking also that says universal = 1) (see here).

For more complex packages (those which includes extensions or that rely on 2to3), it is not clear to me how to do it properly but you can start by supporting simple packages.

from zest.releaser.

jensens avatar jensens commented on July 22, 2024

It would be great to have wheel support and for first i think its enough for 95% of cases to scan for universal wheel support and do the upload then as described by @hgrecco

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

I created a pull request for this. It simply runs the bdist_wheel command at the same time as sdist when the wheel package is available. It does not check setup.cfg. I wonder if that is enough initially, or if we should really check if the package has a setup.cfg with a bdist_wheel section, which could be empty.

The advantage of the simple approach in this pull request is that packages need no changes.

Can we think of existing packages where this is a bad idea?
I am not sure how smart bdist_wheel is about autodiscovering that a correct and sane wheel is created.
Might be safer to check for a bdist_wheel entry in setup.cfg. Or possibly add an option for the zest.releaser section.

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

@mauritsvanrees, you started with a zest.releaser[recommended] list that includes 'wheel' right now. See #49 where you talk about that recommended list.

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

Is on master and will end up in next release (4.0).

from zest.releaser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.