Comments (6)
You're right. I'm not building wheels myself (yet), so I don't have experience with them yet.
You're saying that if there's bdist_wheel
in the setup.cfg
, is it really only a matter of adding the extra bdist_wheel
argument to our call to setup.py
?
Or can there be more that needs to be done? Like making different kinds of wheels?
I really should dive into wheel usage. I'm pretty certain I'll like them :-)
from zest.releaser.
You can build specific wheels using command line switches (docs) but I think that is ok to ask zest.releaser users to have a properly designed setup.cfg
(That is what everybody will do anyway.)
For pure python packages that are compatible with python 2 and 3 I think the suggested approach is valid (Maybe checking also that says universal = 1
) (see here).
For more complex packages (those which includes extensions or that rely on 2to3), it is not clear to me how to do it properly but you can start by supporting simple packages.
from zest.releaser.
It would be great to have wheel support and for first i think its enough for 95% of cases to scan for universal wheel support and do the upload then as described by @hgrecco
from zest.releaser.
I created a pull request for this. It simply runs the bdist_wheel
command at the same time as sdist
when the wheel
package is available. It does not check setup.cfg
. I wonder if that is enough initially, or if we should really check if the package has a setup.cfg
with a bdist_wheel
section, which could be empty.
The advantage of the simple approach in this pull request is that packages need no changes.
Can we think of existing packages where this is a bad idea?
I am not sure how smart bdist_wheel is about autodiscovering that a correct and sane wheel is created.
Might be safer to check for a bdist_wheel
entry in setup.cfg. Or possibly add an option for the zest.releaser section.
from zest.releaser.
@mauritsvanrees, you started with a zest.releaser[recommended]
list that includes 'wheel' right now. See #49 where you talk about that recommended list.
from zest.releaser.
Is on master and will end up in next release (4.0).
from zest.releaser.
Related Issues (20)
- ValueError: binary mode doesn't take an encoding argument HOT 9
- fullrelease: error: no such option: --no-input HOT 8
- sdist is missing tox.ini HOT 1
- tests fails with non-GNU ls HOT 4
- testing: the following arguments are required: message HOT 1
- testing: bumpversion and postrelease tests fails HOT 3
- Always create wheels, when possible HOT 2
- Warn/ask to verify for deprecation notices when making a major release HOT 4
- get_last_tag can fail with recent setuptools HOT 1
- Use build to generate wheels and sdists HOT 7
- Read zest.releaser settings from pyproject.toml HOT 3
- Issue during our dependency-check analysis because of tests/pyproject.toml file HOT 1
- Upload to PyPI fails HOT 6
- readthedocs documentation isn't being build anymore HOT 2
- Issues when trying 'build' HOT 7
- Wheel does not contain the required METADATA file HOT 2
- `build` has changed the ProjectBuilder API in 1.0.0 HOT 2
- index-servers option in setup.cfg not working HOT 5
- implement --version HOT 1
- Support Hatchling as build backend HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zest.releaser.