Giter VIP home page Giter VIP logo

Comments (7)

reinout avatar reinout commented on July 22, 2024

Well, normally everything works with a setup.py.

Allowing a version.txt in the main directory is a left-over from ancient pre-setuptools zope products. But... surprisingly handy if it is a non-setuptools project like some documentation or even something with a Makefile or so.

The error you get is because zest.releaser cannot find a version.txt (which you moved to a subdirectory). In those cases there must be a setup.py, so it reads it. And fails.

I could add a better error message ("neither version.txt or setup.py found"), but that gives too much prominence to the version.txt, which is effectively a corner case (even though I use it myself, too :-) )

I also don't think it is a good idea to start looking in subdirectories for the version.txt. Moving it back into the project root is the quickest solution.

from zest.releaser.

WouterVH avatar WouterVH commented on July 22, 2024

You are too modest, zest.releaser is a great tool even for non-python projects!
In that case the "cornercase" become the main use-case.

I just converted tens of packages to docs/version.rst, docs/changes.rst
I now started to do the same conversion for buildouts which results in a very nice consistency

To be able to release, I currently to need patch

versionfile = self.filefind(['version.txt', 'version'])
into
versionfile = self.filefind(['version.txt', 'version', 'version.rst']) # use TXT_EXTENSIONS

But then I need to make sure all teammembers apply the same patch, or otherwise I'll be the only one able to make releases. :(

IMHO, this seems like a small change to complete #65

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

Ah, I see.

a) I forgot that zest.releaser checks in subdirectories :-)

b) Hey, I forgot to add the TXT_EXTENSIONS fix to the spot you've indicated.

I've fixed it in 1dc7628

(I forgot to make a branch, so it isn't a pull request).

I'm trying to upload 3.53.1, but pypi upload is failing for me.

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

https://sourceforge.net/p/pypi/support-requests/438/

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

@WouterVH can you try 3.53.2? The upload finally succeeded :-)

from zest.releaser.

mauritsvanrees avatar mauritsvanrees commented on July 22, 2024

For the record/clarity:

  • At Zest we add version.txt in the buildout root of our client projects and use zest.releaser to make tag releases.
  • For old Zope/Plone Products, I expect the version to be in a sub directory, for example Products/Poi/version.txt.

from zest.releaser.

reinout avatar reinout commented on July 22, 2024

Ok, then the version.txt (note: version.rst is fine, too, now) is in more widespread use than I thought.

All my buildouts also have setup.py that lists all the dependencies, so I already have a place for the version :-)

I assume it all works OK, so I'm closing this issue.

from zest.releaser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.