setup.py not always able to update version, so error? about zest.releaser HOT 5 CLOSED

zest.releaser doesn't continue deliberately :-) A version that's not in setup.py or version.txt is mostly a corner case. That corner case plus the additional corner case of not setting python_file_with_version... Two corner cases in a row is too much for poor zest.releaser.

Your proposal looks ok, though :-) I'd probably add a version_written = False line just above https://github.com/zestsoftware/zest.releaser/blob/master/zest/releaser/vcs.py#L213 and set it to True after https://github.com/zestsoftware/zest.releaser/blob/master/zest/releaser/vcs.py#L222 . And an exception if it didn't work. Something like that?

from zest.releaser.

Hi Reinout, granted it's corner case, but thanks for approving the issue :-)

I started off with your suggestion but ended up refactoring a tiny bit. See what you think.

#71

from zest.releaser.

I merged #71, but I made the error logging a bit more elaborate. I'll release later this morning.

from zest.releaser.

I released 3.55. Can you check if it works for you?

from zest.releaser.

Just checked with my original package, and:

prerelease --verbose
...
Enter version [0.1.0]: 0.2.1
...
ERROR: We could read a version from setup.py, but could not write it back. See http://zestreleaser.readthedocs.org/en/latest/versions.html for hints.
Traceback (most recent call last):
...
RuntimeError: Cannot set version

👍 Nice doing business with you! Thanks

from zest.releaser.