Comments (5)
zest.releaser doesn't continue deliberately :-) A version that's not in setup.py or version.txt is mostly a corner case. That corner case plus the additional corner case of not setting python_file_with_version... Two corner cases in a row is too much for poor zest.releaser.
Your proposal looks ok, though :-) I'd probably add a version_written = False
line just above https://github.com/zestsoftware/zest.releaser/blob/master/zest/releaser/vcs.py#L213 and set it to True after https://github.com/zestsoftware/zest.releaser/blob/master/zest/releaser/vcs.py#L222 . And an exception if it didn't work. Something like that?
from zest.releaser.
Hi Reinout, granted it's corner case, but thanks for approving the issue :-)
I started off with your suggestion but ended up refactoring a tiny bit. See what you think.
from zest.releaser.
I merged #71, but I made the error logging a bit more elaborate. I'll release later this morning.
from zest.releaser.
I released 3.55. Can you check if it works for you?
from zest.releaser.
Just checked with my original package, and:
prerelease --verbose
...
Enter version [0.1.0]: 0.2.1
...
ERROR: We could read a version from setup.py, but could not write it back. See http://zestreleaser.readthedocs.org/en/latest/versions.html for hints.
Traceback (most recent call last):
...
RuntimeError: Cannot set version
from zest.releaser.
Related Issues (20)
- Prevent the creation of universal wheel with Python 3 only package. HOT 3
- Check that main branch is up to date with remote HOT 4
- Support Markdown file validation under longtest HOT 1
- support projects with pep517 deps HOT 10
- index-servers vs. index_servers HOT 3
- postrelease minor/patch version HOT 6
- Passing version as a command-line parameter to `prerelease` and `fullrelease` HOT 2
- Unexpected `prerelease` behaviour with Changelog containing markdown links HOT 2
- Documentation: hook_package_dir en entrypoints section.
- support [tool:zest.releaser] in setup.cfg HOT 2
- support pep621 HOT 4
- Future plans for zest.releaser HOT 4
- Prefixing git tags with a "v" HOT 2
- Check version for PEP440 HOT 3
- bumprelease functionality HOT 6
- zest.releaser with plone.releaser breaks when not in a buildout.coredev environment HOT 3
- Failed git push does not fail release HOT 6
- Possibility to add prefix to commit messages HOT 6
- ValueError: binary mode doesn't take an encoding argument HOT 9
- fullrelease: error: no such option: --no-input HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zest.releaser.