Comments (4)
Hi,
I'll have a look. I don't think there is anything wrong with this line, so moving to filter_var()
with FILTER_VALIDATE_EMAIL
was probably the wrong choice.
Do you have a set of emails that are now broken, and also your original broken one from the issue in civic that you linked to? We can then add these as test cases.
cheers,
Derick
from mail.
I had a little dive into RFCs, and filter_var()
does do this correctly. Local parts are limited to 64 octets, and your example "email address" has more.
I do think it is important that we validate this, and that we don't just return null
when it isn't valid. I also believe that when parsing we should be more lenient in what we accept.
My suggestion would be to use the regex from PHP's filter_var()
and extend the length limits. The PR at #91 does this, and extends it from 64 to 124.
from mail.
I've merged this, and also released 1.9.6.
from mail.
Thanks for being so helpful @derickr
from mail.
Related Issues (20)
- Feature request: add alias for the 'unicode-1-1-utf-7' charset HOT 2
- Force parse text file attachment as file when Content-Disposition: attachment header HOT 4
- File name too long when parsing attachments HOT 7
- Flags not fetched correctly from GMail HOT 1
- Iconv error on zetacomponents/mail/src/internal/charset_convert.php line 14 HOT 2
- User names and passwords can contain spaces. HOT 1
- bug in parser/parts/text_parser.php HOT 4
- create_function() is deprecated in PHP 7.2
- How to use Zeta Mail Component in Laravel HOT 1
- IMAP TLS Auth for accessing mailbox HOT 1
- Notice: iconv(): Detected an illegal character in input string HOT 1
- Attachment filename too long HOT 2
- Incompatible regex with PHP 7.3 HOT 3
- ezcMailTools::mimeHeaderEncode Timeout HOT 2
- Issue with civicrm-core HOT 2
- Undefined variable in imap_set.php HOT 1
- .msg attachment HOT 4
- Curly-brace syntax for array and string access is deprecated in PHP 7.4 HOT 1
- IMAP / POP
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mail.