Giter VIP home page Giter VIP logo

Comments (9)

zhangao0086 avatar zhangao0086 commented on May 23, 2024

Hi @AnthonyMDev

You are so right! I didn't think about it before! I'll appreciate it If you make a pull request to me :)

from dkimagepickercontroller.

AnthonyMDev avatar AnthonyMDev commented on May 23, 2024

I can make the PR. Quick question, I'm thinking that this should remove the button text that says Select(#) with the # being updated as you select images. Currently, Facebook just has a static Done button. Is that okay? Or would you like to keep that functionality and just switch it to say Done when there are 0?

I'm also thinking this means we remove the Cancel button?

from dkimagepickercontroller.

zhangao0086 avatar zhangao0086 commented on May 23, 2024

I think Facebook is right that Cancel button is not necessary. And I would like to keep that Select and switch it to Done when there are 0 as you said :)

from dkimagepickercontroller.

AnthonyMDev avatar AnthonyMDev commented on May 23, 2024

I got busy this week and forgot about this, sorry! I'll try to get to it next week.

from dkimagepickercontroller.

zhangao0086 avatar zhangao0086 commented on May 23, 2024

Never mind :)

from dkimagepickercontroller.

AnthonyMDev avatar AnthonyMDev commented on May 23, 2024

Why never mind? I plan on working on this now. Do you not want to pull it anymore?

from dkimagepickercontroller.

AnthonyMDev avatar AnthonyMDev commented on May 23, 2024

Alright, I've finished this with PR #41.

@zhangao0086 Hope that works for you. I'd love to see a new version of the pod with this included soon!

Thanks.

from dkimagepickercontroller.

zhangao0086 avatar zhangao0086 commented on May 23, 2024

I'm sorry for my words! I mean "Never mind" for your "sorry". Actually, I'm glad to see your PR. There is no doubt that will help the pod gets better!🍺🍺🍺

from dkimagepickercontroller.

zhangao0086 avatar zhangao0086 commented on May 23, 2024

Thanks for your PR!!!

from dkimagepickercontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.