Comments (9)
Hi @AnthonyMDev
You are so right! I didn't think about it before! I'll appreciate it If you make a pull request to me :)
from dkimagepickercontroller.
I can make the PR. Quick question, I'm thinking that this should remove the button text that says Select(#)
with the # being updated as you select images. Currently, Facebook just has a static Done
button. Is that okay? Or would you like to keep that functionality and just switch it to say Done
when there are 0?
I'm also thinking this means we remove the Cancel
button?
from dkimagepickercontroller.
I think Facebook is right that Cancel
button is not necessary. And I would like to keep that Select
and switch it to Done
when there are 0 as you said :)
from dkimagepickercontroller.
I got busy this week and forgot about this, sorry! I'll try to get to it next week.
from dkimagepickercontroller.
Never mind :)
from dkimagepickercontroller.
Why never mind? I plan on working on this now. Do you not want to pull it anymore?
from dkimagepickercontroller.
Alright, I've finished this with PR #41.
@zhangao0086 Hope that works for you. I'd love to see a new version of the pod with this included soon!
Thanks.
from dkimagepickercontroller.
I'm sorry for my words! I mean "Never mind" for your "sorry". Actually, I'm glad to see your PR. There is no doubt that will help the pod gets better!
from dkimagepickercontroller.
Thanks for your PR!!!
from dkimagepickercontroller.
Related Issues (20)
- adding Ukrainian localization (uk)
- How to display overlay image on camera
- ios 14.6 not getting all the selected images HOT 1
- How to change color of selected images HOT 6
- Top picker bar is transparent in iOS15
- Camera icon not showing when deploying in xcode13 HOT 3
- Localization not working
- Compilation error: "LLVM ERROR: out of memory" HOT 11
- Xcode 13.3 - Error (Xcode): Segmentation fault: 11 Encountered error while archiving for device. HOT 35
- Crash on DKCamera.captureImage function HOT 1
- How to get original files URLs?
- Xcode 14: Swift Compiler Error: Stored properties cannot be marked potentially unavailable with '@available' HOT 4
- ios error Signing for "DKImagePickerController-DKImagePickerController" requires a development team. HOT 14
- After changing to 4.3.4, Now i cant compile with BITCODE enabled HOT 4
- XCode 14 Build error: Stored properties cannot be marked potentially unavailable with '@available' HOT 16
- I want to export the video to .mp4
- xcode14中不兼容ios12系统
- No Actions when clicking in Camera Icon, it should open camera to capture
- How to perform Multiple Image selection but only single video selection
- Xcode 13 升级 14后,运行到真机没有问题但是打包会报错 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dkimagepickercontroller.