No return if buffer is too big about lamejs HOT 3 CLOSED

Ok i have found a solution i don't know if its the current way but its working. Perhaps the i can change the documentation if its missing there.

My solution is to forEach over the result and add the values:

// Encode main data
var sampleBlockSize = 1152;
for (var x = 0; x < samples.length; x += sampleBlockSize) {
    var sampleChunk = samples.subarray(x, x + sampleBlockSize);
    var mp3buf = mp3encoder.encodeBuffer(sampleChunk);
    if (mp3buf.length > 0) {
        mp3buf.forEach(function(val) {
            mp3Data.push(val);
            });
            }
    }

// Flush and set last data to mp3Data
mp3Data.push(mp3encoder.flush());
mp3Data = new Int8Array(mp3Data);

After that convert it back to an Int8Array. Its possible that this errors came because i use RecordRTC. But when the recording is longer then 1 minute i the browser hand :/

And another thing is that if the recording is a bit longer i record 20 or 30 Seconds and get a 7 minutes MP3? It takes a long time to convert them.

I have made some debugging and i've found some interessting things. If the recording is less then 20 seconds the encoded buffer length is 384

var mp3buf = mp3encoder.encodeBuffer(sampleChunk);
console.log(mp3buf.length);

And the recoding is correct. If the recoding is bigger then 20 Seconds i get another result then its 8639 the result is not correct and the MP3 is much longer.

from lamejs.

If you are pushing the result of encode into an array, you are right you will get an array of arrays. The reason I do that in my code is that I then create a blob new Blob(blocks, {type: 'audio/mpeg'}); which can process multiple arrays of data. If you aren't using a Blob, you'll want a different way of storing/processing the data. Your foreach is one option, a concat might be simpler. It all depends on what you are going to do with the output.

from lamejs.

I've tried now a lot of things and its not usable. After 20 seconds you get unusable data which are a lot longer then the original data. So its not working. I have now another solution without lamejs and zip the data and convert them on my server. I can't find another solution. Its really sad then i think the idea of lamejs is very good.

from lamejs.