Giter VIP home page Giter VIP logo

Comments (9)

bago avatar bago commented on June 19, 2024 1

Weird. KO 3.4.0 removed the ko.DEBUG variable... so we need a new way to detect debug vs compiled version... it seems that ko.subscriptions is a function defined only in DEBUG versions, so we may "stick" to that.

from knockoutjs-reactor.

jerackista avatar jerackista commented on June 19, 2024 1

Yes it looks fine now for me. Thanx

from knockoutjs-reactor.

bago avatar bago commented on June 19, 2024

First, try reactor 1.3.8 because I added support for KO 3.4.1 in 1.3.8.
Second: it's weird that you get a "K" error on the DEBUG version of knockout: I guess you missed something.. please double check what version of knockout you are using... try running "ko.DEBUG" in console to see if you really have a debug version of knockout and try "ko.version" to see the loaded version.

from knockoutjs-reactor.

Domysee avatar Domysee commented on June 19, 2024

I got the same error when disposing the subscription. Also only when using the debug version, but I'm using KO 3.4.0 and reactor 1.3.8.

from knockoutjs-reactor.

bago avatar bago commented on June 19, 2024

what does ko.DEBUG in console says?
can you create a jsbin/jsfiddle to show the isssue?

from knockoutjs-reactor.

Domysee avatar Domysee commented on June 19, 2024

ko.DEBUG is undefined.
I'll try to, but it may take a while, at the moment I don't have much time.
My fix for now is to just not use the debug version.

from knockoutjs-reactor.

bago avatar bago commented on June 19, 2024

Hi I "blindly released" 1.3.9 with a fix to support debug versions of KO 3.4.0 and 3.4.1, that seems to have removed the ko.DEBUG variable export.

Please let me know if this fix your issue.

from knockoutjs-reactor.

bago avatar bago commented on June 19, 2024

Thank you for reporting and for the final feedback!

from knockoutjs-reactor.

tamanugi avatar tamanugi commented on June 19, 2024

I got same error when using with knockout 3.4.2.
guess subscriptionsField change to F.

     var subscriptionsField;
    switch (typeof ko.subscription == 'function' || ko.version) {
    case true: subscriptionsField = '_subscriptions'; break;
    case '3.0.0': subscriptionsField = 'F'; break;
    case '3.1.0': subscriptionsField = 'H'; break;
    case '3.2.0': subscriptionsField = 'M'; break;
    case '3.3.0': subscriptionsField = 'G'; break;
    case '3.4.0': subscriptionsField = 'K'; break;
    case '3.4.1': subscriptionsField = 'K'; break;
-   case '3.4.2': subscriptionsField = 'K'; break;
+  case '3.4.2': subscriptionsField = 'F'; break;
    default: throw 'Unsupported Knockout version. Only v3.0.0 to v3.4.2 are supported when minified. Current version is ' + ko.version;

After correcting as described above it worked properly

from knockoutjs-reactor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.