Warning when using React 0.14 about react-slider HOT 20 CLOSED

Ah, thank you for trying the component with react 0.14.

I've heard of this change, but I don't know how to best handle it, so that the component can be used with react 0.13 and 0.14.
Checking for getDOMNode to be defined seems like a pretty brute way to do it :/
Happy to receive any input concerning this.

from react-slider.

Yeah, I'm not sure either what is the best way to go forward with this, without breaking backwards comparability. In React 0.14, this is only a warning, so maybe is should just stay like it is until it will be totally deprecated.

from react-slider.

Now would be the time to fix the warning so the component doesn't break when it is totally deprecated.
I assume there will be a suggested way of handling this once 0.14 is released. Or we just add the check...

from react-slider.

I think .findDOMNode() replaces it, no?
http://www.omerwazir.com/posts/react-getdomnode-replaced-with-findDOMNode/

from react-slider.

@canfie1d That change was introduced in React 0.13, but 0.14 includes further changes. findDOMNode() is no longer a part of the react package, but rather a new react-dom package. Also, refs that point to a DOM component now are the DOM node, and should not be wrapped with findDOMNode(). See more here in the React 0.14 blog post

from react-slider.

Ah- I see. Thanks for that.

from react-slider.

Looks like the right way to release new version of a package with strict dependency to react 0.14.

PS. Similar idea: moroshko/react-autosuggest@4ab699d

from react-slider.

Thanks for looking it up 👍

from react-slider.

Any news on that ? react 0.14 is out now.

Instead of findDOMNode, just use refs:

render() {
    return <div ref='element'></div>;
}

doSomething() {
    console.log(this.refs.element); // will print the node element to the console
}

from react-slider.

I too am looking forward to .14 support.

from react-slider.

The warning stops happening if you just remove the ".findDOMNode()" from 2 places in the code.

from react-slider.

I submitted a PR for that, but the maintainer seems inactive.

from react-slider.

@KeitIG your PR doesn’t seem to update package.json or handle compatibility with 0.13

from react-slider.

True dat, doing it asap.

from react-slider.

Done.

from react-slider.

👍

from react-slider.

Waiting fix too. @KeitIG Thanks

from react-slider.

@Martindelataille, yep, would be great if the PR was accepted now :)

from react-slider.

Issue can be closed now a new version is released. poke @hugihlynsson

from react-slider.

Super!

from react-slider.