Comments (5)
Difficult to explain. So originally I was using transform
for positioning, but it caused some problems with existing transform
s on the handles. That's probably the component you are seeing. After that I switched to absolute positioning, but still pixel based.
For the rewrite of the component I'm sticking with absolute positioning, despite the performance implications because
- it allows to position the handles without knowing the size of the slider, which solves all the visibility related problems
- the bars between the handles have to be positioned absolute anyway (I think in theory it would be possible to do it with
scale()
, but that won't do well with bars that have a background image)
from react-slider.
Oh ok, so the demo is using old code?
Why are you using px based values instead of percentage based?
from react-slider.
Yes. The reason is that percentage based positioning via transform is relative to the size of the element being transformed (i.e. setting transform: translateX(50%)
on a handle will offset it by 50% of its width, which is not what we want)
from react-slider.
@qwtel any chances of unifying the two packages or updating this one to accept React 0.14 ?
from react-slider.
Hi, I noticed the same discrepancy and have a question. The code base is not positioning the handles correctly and for some reason seems to ignore the position: relative
from the slider. My question is how do I fix this issue?
from react-slider.
Related Issues (20)
- React 18.3: A props object containing a "key" prop is being spread into JSX HOT 4
- First click on track doesn't work when slider value is array and array values is equal
- Typescript issue HOT 1
- Possible to use a gradient as background for the slider? HOT 1
- Feature request: provide a way of detecting when react-slider has/loses focus HOT 2
- The specified value "1,669" cannot be parsed, or is out of range. HOT 1
- disabled does not apply to child elements?
- [TypeScript] `renderThumb`
- Module not found: Error: Can't resolve '@babel/runtime/helpers/inheritsLoose' HOT 4
- How to handle key events when I have global listeners? HOT 2
- Thumb Incorrect positioning HOT 1
- Slider not changing value when running Cypress tests HOT 3
- Wrong index in change event when changing thumb value through click
- No option to remove the slider thumb from the 'tab flow' HOT 1
- README.md file should be updated for how to use the packege HOT 2
- Missing dependency: @babel/runtime HOT 1
- Styling instructions are out of date
- Not working on Scaled Div
- Possible Incorrect State Management
- Incompatibility with React Testing Library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-slider.