Giter VIP home page Giter VIP logo

Comments (9)

grouzen avatar grouzen commented on August 25, 2024

@grogdotcom
I've tried to set attributes for a span created by auto-instrumentation in this PR: https://github.com/zio/zio-telemetry/pull/715/files.
It works well. Of course, in the example, the span is provided by Netty instrumentation.
Could you please elaborate more on which libraries you use for Kafka and grpc?

from zio-telemetry.

Gregory-Berkman-Imprivata avatar Gregory-Berkman-Imprivata commented on August 25, 2024

@grouzen I am using zio-grpc v0.6.0-rc5 and zio-kafka v2.3.1. Auto insrumentation is working fine for both. I am not seeing any custom attributes attached to the autoinstrumented spans when I receive the request on the server/consumer side. I am using opentelemetry version 1.18.0.
I just tried upgrading my opentelemetry version to 1.26.0 but am seeing the same behavior
The telemetry version in the jaeger trace is telemetry.sdk.version: 1.19.0

from zio-telemetry.

grouzen avatar grouzen commented on August 25, 2024

The telemetry version in the jaeger trace is telemetry.sdk.version: 1.19.0

That looks suspicious to me. It should be 1.26.0 for auto-instrumented spans if you use this version in -javaagent option.

from zio-telemetry.

grouzen avatar grouzen commented on August 25, 2024

@Gregory-Berkman-Imprivata Hey! Have you managed to solve it?

from zio-telemetry.

Gregory-Berkman-Imprivata avatar Gregory-Berkman-Imprivata commented on August 25, 2024

@grouzen Unfortunately no, I decided to just manually instrument these traces

from zio-telemetry.

grouzen avatar grouzen commented on August 25, 2024

Okay! I hope we will solve it somehow in the future, so I'll leave the issue open for now.

from zio-telemetry.

omidb avatar omidb commented on August 25, 2024

@Gregory-Berkman-Imprivata can you elaborate a bit on this? I have the same issue: scalapb/zio-grpc#544

from zio-telemetry.

omidb avatar omidb commented on August 25, 2024

A working example here scalapb/zio-grpc#544 and @grouzen we can close it. maybe even add an example in the future.

from zio-telemetry.

grouzen avatar grouzen commented on August 25, 2024

Thank you! Great stuff!
Here is the follow-up issue to add gRPC examples: #751

from zio-telemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.