Scala 2.13 - cannot compare child class to parent class in assertTrue about zio HOT 8 CLOSED

Now when I think about it - maybe it should work that way? I guess the issue is Scala 3 allowing that ...

I was wrong (from equals Javadoc):

The equals method implements an equivalence relation on non-null object references:

It is symmetric: for any non-null reference values x and y, x. equals(y) should return true if and only if y. equals(x) returns true.

from zio.

It seems like c.inferImplicitValue does not work for function B => A if they are descendants.

https://docs.scala-lang.org/overviews/quasiquotes/syntax-summary.html#types - tq in ZIO's case return Tree which returns null for .tpe

from zio.

Hey @andrzejressel, I was going to link this issue on why I think this behaviour is correct for Scala 2 but not for Scala 3, but then I realised you were the one that opened it 😅

Why do you think that in this case Scala 3's behaviour is correct but not Scala 2's?

from zio.

They are both a bit scuffed - basically I believe that all directly related classes should be comparable in any order.

In Scala 2.13 it didn't work because of bug with implicit conversion finding, in Scala 3 it does not work because this conversion is not implemented for equals (only for > >= < <= comparisons).

EDIT: Even equals JavaDoc agrees with that - comparing parent to child should (must?) return the same as comparing child to parent.

from zio.

/bounty $75

from zio.

💎 $75 bounty • ZIO

Steps to solve:

1. Start working: Comment /attempt #8874 with your implementation plan
2. Submit work: Create a pull request including /claim #8874 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio!

Add a bounty • Share on socials

from zio.

💡 @andrzejressel submitted a pull request that claims the bounty. You can visit your bounty board to reward.

from zio.

🎉🎈 @andrzejressel has been awarded $75! 🎈🎊

• Share on socials
• Give feedback

from zio.