Comments (10)
- Maybe it makes sence to create an eventstore clienthelper before we start refactoring, because eventstore client produces a lot of repeated code
from zitadel.
- Config handling got too complex (management especially)
from zitadel.
- Tests:
`
func Test_ExistisPerm(t *testing.T) {
type args struct {
existing []string
perm string
}
tests := []struct {
name string
args args
result bool
}{
{
name: "not existing perm",
args: args{
existing: []string{"perm1", "perm2", "perm3"},
perm: "perm4",
},
result: false,
},
{
name: "existing perm",
args: args{
existing: []string{"perm1", "perm2", "perm3"},
perm: "perm2",
},
result: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := ExistsPerm(tt.args.existing, tt.args.perm)
if result != tt.result {
t.Errorf("got wrong result, expecting: %v, actual: %v ", tt.result, result)
}
})
}
}
`
from zitadel.
- Logging and loglevels (@fgerschwiler i moved this to a seperate issue)
from zitadel.
Tracing (@fgerschwiler i moved this to a seperate issue)
- Add in auth to find out where we have performance problems
- implement more where needed
from zitadel.
What is public and what private, eg id in paramet of a function should be private (lower case)
Define how to write abbreviations like ID, IAM, URL
from zitadel.
- converting method naming concept
from zitadel.
- test files in other package --> (Gleiches Package)
from zitadel.
- I would rename the method
Process
ofeventstore/pkg/query/Handler
interface toReduce
from zitadel.
- define where to set search limit ( app)
from zitadel.
Related Issues (20)
- Actions: Use organization metadata in external authentication flow
- Actions: Provide a way to set a different external user id in external authentication flow HOT 1
- CLI: migrate database command
- Add the possibility to set a custom user profile url HOT 1
- SAML IDP: Ability to customize the SAML EntityID
- Display application name instead of client ID in device authorization grant message HOT 5
- [Bug]: v1 features are not correctly migrated to v2 features HOT 2
- [Bug]: Instant redirect to IDP does not work correctly HOT 1
- [Bug]: Authentication redirection flow HOT 10
- MAU and DAU Metrics HOT 1
- [Bug]: Country selection for mobile verification needs bigger min width HOT 1
- [Bug]: Domain Discovery Issues - ID=QUERY-1kIjX Message=Instance not found. HOT 20
- [Bug]: Docker Compose files in `./e2e/` not usable since latest Docker Compose release. HOT 3
- [Bug]: Login via E-Mail should be case insensitive HOT 3
- [Bug]: Unable to setup project with brand-new installation HOT 5
- [Bug]: Branding Setting modal not styled correctly HOT 1
- 2FA form improvements
- External User Grant
- [Bug]: Incorrectly rendered SVG while initializing user HOT 4
- [Bug]: Create User API endpoint not fulfilling reliable HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zitadel.