Giter VIP home page Giter VIP logo

Comments (10)

adlerhurst avatar adlerhurst commented on May 9, 2024 1
  • Maybe it makes sence to create an eventstore clienthelper before we start refactoring, because eventstore client produces a lot of repeated code

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024 1
  • Config handling got too complex (management especially)

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024
  • Tests:

`
func Test_ExistisPerm(t *testing.T) {

type args struct {
	existing []string
	perm     string
}
tests := []struct {
	name   string
	args   args
	result bool
}{
	{
		name: "not existing perm",
		args: args{
			existing: []string{"perm1", "perm2", "perm3"},
			perm:     "perm4",
		},
		result: false,
	},
	{
		name: "existing perm",
		args: args{
			existing: []string{"perm1", "perm2", "perm3"},
			perm:     "perm2",
		},
		result: true,
	},
}
for _, tt := range tests {
	t.Run(tt.name, func(t *testing.T) {
		result := ExistsPerm(tt.args.existing, tt.args.perm)
		if result != tt.result {
			t.Errorf("got wrong result, expecting: %v, actual: %v ", tt.result, result)
		}
	})
}

}
`

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024
  • Logging and loglevels (@fgerschwiler i moved this to a seperate issue)

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024

Tracing (@fgerschwiler i moved this to a seperate issue)

  • Add in auth to find out where we have performance problems
  • implement more where needed

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024

What is public and what private, eg id in paramet of a function should be private (lower case)
Define how to write abbreviations like ID, IAM, URL

from zitadel.

hifabienne avatar hifabienne commented on May 9, 2024
  • converting method naming concept

from zitadel.

hifabienne avatar hifabienne commented on May 9, 2024
  • test files in other package --> (Gleiches Package)

from zitadel.

adlerhurst avatar adlerhurst commented on May 9, 2024
  • I would rename the method Process of eventstore/pkg/query/Handler interface to Reduce

from zitadel.

hifabienne avatar hifabienne commented on May 9, 2024
  • define where to set search limit ( app)

from zitadel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.