latest archiver versions break pptx output in some cases about officegen HOT 6 CLOSED

see also: archiverjs/node-archiver#60

from officegen.

Thanks for letting me know about it.

I'll do lock it to 0.4.10

On Fri, Feb 7, 2014 at 2:02 AM, Seth Pollack [email protected]:

see also: archiverjs/node-archiver#60archiverjs/node-archiver#60

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-34394203
.

from officegen.

i highly recommend ~ over >= specially if a project isn't past 1.0.0. while i try to prevent breaking changes, i consider every minor version (before 1.0.0) to be a new version of api for interacting.

from officegen.

Thanks guys.

from officegen.

really should be catching the error and either emitting it back to archive (for existing handler to work) or call done(err). due to the way that people used to use async module (which btw isnt required anymore, archiver handles queue internally) so emitting an error when they have a callback would sidestep their processes. I plan to go all events in archive v0.6.0 instead of callbacks but thats a month out or so.

from officegen.

definitely we should be checking and handling errors from archiver here in the officegen code. this should also help get info on whatever root problem was causing these failures for me earlier.

from officegen.