feature request: callback to generate() about officegen HOT 4 CLOSED

Sorry about the late response....
You can also pass a callback:

var officegen = require('officegen');

var pptx = officegen ({
'type': 'pptx', // or 'xlsx', etc
'onend': function ( written ) {
console.log ( 'Finish to create a PowerPoint file.\nTotal bytes
created: ' + written + '\n' );
},
'onerr': function ( err ) {
console.log ( err );
}
});

On Wed, Oct 23, 2013 at 7:59 PM, Seth Pollack [email protected]:

Right now i have to listen on the finalize event to know when a pptx has
been written out. it would be great to be able to pass a callback instead
to generate. The reason is that i'm writing using streamline (
https://github.com/Sage/streamlinejs) and it doesn't mesh well with event
emitters. I wrote a wrapper for now that listens for the events, and maps
it into a callback.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

from officegen.

Thanks, i did see that. The issue is that the lifecycle is a bit atypical here. I call var pptx = officegen (...), which returns synchronously, then i do arbitrary work to build all my slides, then only when i call pptx.generate(...) does the onend callback from that first call fire (asynchronously). typically this callback would be associated with the generate call, since that is where the async work happens, not the officegen call. If it was set up that way, it would be a smoother integration for me.

That said, i've already written a wrapper, so this is low priority, you can fix or close as you see fit ;-) Thanks!

from officegen.

Please use the last commit, you can now pass the finalize callback to generate()

from officegen.

great, thanks!

from officegen.