Giter VIP home page Giter VIP logo

Comments (9)

zjes avatar zjes commented on July 28, 2024

May you look to 6e5171d. It will be ok?

from lxqt-appswitcher.

pmattern avatar pmattern commented on July 28, 2024

Mnemonics are working exactly as expected now.

I just think it would be good if you updated ./config/translations/lxqt-config-appswitcher.ts accordingly.
This would make translators consider them while translating and at the same time suppress some unnecessary error messages of Qt Linguist which result from adding mnemonics in translations right now.

from lxqt-appswitcher.

zjes avatar zjes commented on July 28, 2024

Yes, i decide to commit common things before *.ts. If something was wrong. :)

from lxqt-appswitcher.

pmattern avatar pmattern commented on July 28, 2024

Yes, i decide to commit common things before *.ts. If something was wrong

That makes sense.

from lxqt-appswitcher.

zjes avatar zjes commented on July 28, 2024

I've updated translations. But one problem, cannot solve it yet (maybe local). Strings with & not shown translated.

from lxqt-appswitcher.

pmattern avatar pmattern commented on July 28, 2024

String & which is used to mark the mnemonics needs to be included in the translated strings as well, e. g. something like Max &položek k zobrazení.

The TS files currently available still feature tag type="unfinished" besides the corresponding strings have already been translated. This ought to be fixed.
Qt Linguist marks errors like that and makes them easy to discover and fix, see also.

To my knowledge it's common practice to add & not in template file *.ts in the directories comprising the translated TS files *_foo.ts but primarily in the source code.
E. g. compare https://github.com/lxde/obconf-qt/blob/e21185158924856a3456400b05df066bcc7fb784/src/obconf.ui#l120 with https://github.com/lxde/obconf-qt/blob/e21185158924856a3456400b05df066bcc7fb784/src/translations/obconf-qt.ts#l82 (sure enough the wrong source code file is referenced in obconf-qt.ts but the concept applies nevertheless). Once included in the source code strings & are transferred to the template TS file *.ts when the latter gets generated automatically by running lupdate or whatever. String & has nevertheless to be added to the translated strings manually as stated above after the template TS file gets copied to the language specific files *_foo.ts and these get edited.
My knowledge of all that stuff is rather superficial, though.

from lxqt-appswitcher.

zjes avatar zjes commented on July 28, 2024

Thank you. It was my installation error. :)

from lxqt-appswitcher.

zjes avatar zjes commented on July 28, 2024

So, how are you with translations? It's ok? Close this issue? :)

from lxqt-appswitcher.

pmattern avatar pmattern commented on July 28, 2024

Regarding the source code and the template TS files lxqt-appswitcher.ts and lxqt-config-appswitcher.ts everything is alright as far as I can tell.
German translation proposed in #9 works as expected.
Regarding the preexisting Czech and Russian translations the problems stated in the first two paragraphs of my previous comment persist. Due to the first one mnemonics aren't available using these translations, the second one makes tools like Qt Linguist throw superfluous warnings. Your mileage may vary.

But no matter whether or not you decide to adjust those two preexisting translations this issue can now indeed be considered fixed, yes.

from lxqt-appswitcher.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.