Giter VIP home page Giter VIP logo

Comments (3)

mgedmin avatar mgedmin commented on July 18, 2024

I see this in BTrees/_compat.h:

#if PY_MAJOR_VERSION >= 3
...
#define INT_GETMAX(x) 2<<31
...
#else
...
#define INT_GETMAX(x) PyInt_GetMax(x)
...
#endif

I see that CPython 2.x had a PyInt_GetMax() that returned LONG_MAX (from <limits.h>). I suggest using it here.

I also wonder why INT_GETMAX is defined as taking an argument, since PyInt_GetMax() doesn't accept one. The only use of the INT_GETMAX macro in BTreeModuleTemplate.c doesn't pass any:

        maxint = INT_GETMAX();

(maxint is of type PY_LONG_LONG, which means it's big enough to hold LONG_MAX)

from btrees.

tseaver avatar tseaver commented on July 18, 2024

a45ebca passes all tests on the winbot and my 64-bit Linux. I need Paul to try on his 32-bit OS/X box.

from btrees.

tseaver avatar tseaver commented on July 18, 2024

Fix released with 4.0.7 after Paul confirmed build / tests OK.

from btrees.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.