Comments (1)
Looks like there is a @Redirect
in BetterCombat that is conflicting with a @ModifyVariable
in LevelZ. Because of the @Redirect
, the target that LevelZ is trying to get to isn't there anymore, so it crashes.
The code in question is as follows:
-- Better Combat --
PlayerEntityInject#replaceSword
@Redirect(method = "attack(Lnet/minecraft/entity/Entity;)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/item/ItemStack;getItem()Lnet/minecraft/item/Item;"))
public Item replaceSword(ItemStack instance) {
if (WeaponRegistry.getAttributes(instance) != null) {
return Items.AIR;
} else {
return instance.getItem();
}
}
-- LevelZ --
PlayerEntityMixin#attackMixin
@ModifyVariable(method = "attack", at = @At(value = "INVOKE", target = "Lnet/minecraft/item/ItemStack;getItem()Lnet/minecraft/item/Item;"), ordinal = 2, require = 0)
private boolean attackMixin(boolean original) {
if (playerEntity.world.random.nextFloat() < (float) playerStatsManager.getLevel("luck") * ConfigInit.CONFIG.luckCritBonus) {
isCrit = true;
return true;
} else
isCrit = false;
return original;
}
from bettercombat.
Related Issues (20)
- Blocking/Defensive options for Weapons HOT 3
- It's basically unhittable when attacking small zombies through half a brick. HOT 1
- forge 1.19.2 exit code -1 problem HOT 1
- neoforge 1.20.1 support/build HOT 1
- Negative Attack Speed HOT 5
- First-person Model API Usage HOT 2
- Lower forge version to make it work with neoforge.... again HOT 3
- Support for 1.20.4 HOT 5
- Potential compatibility with Domestication Innovation HOT 1
- Option to hit first target instead of cleaving HOT 1
- Crash on version 1.20.4 HOT 3
- Crashing in version 1.20.4
- [1.20.1] Crashing after leaving and rejoining a certain world HOT 2
- Spanish translation not working HOT 1
- Crashes in 1.20.4 HOT 1
- Minecraft crashes due to better combat HOT 2
- Better combat / Salami , Pepperoni Debate HOT 4
- Add Javelin to "Trident" style weapon class in fallback config HOT 1
- offhand item disappears when holding two handed wepon HOT 5
- Swapping any two-handed weapon from offhand slot to hotbar voids the weapon HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bettercombat.