Settings about antlr4parsetreevisualizer HOT 4 CLOSED

Initially, I see the following workflow:

On visualizer start:

1. Create a new settings object (TODO we can check if the file exists and read from the file if it does)
2. pass the settings object to the debuggee side using TransferObject
3. get back VisualizerData with the settings object
4. (TODO we can save the current settings to the file at this point)

When the settings popup is opened:

• Clone the settings object -- dedicated Clone method, stores the original as a private field
• Set the datacontext of the popup to the cloned object
• IsChanged property compares current values to original values, in original object
• On poup close, if IsChanged, then reload data context using TransferObject

This has one limitation -- settings cannot be modified on the VisualizerData itself; there has to be some step that says "I've finished modifying the settings, now reload." In this case, it's the popup close.

But this makes sense for changes to settings that require the debuggee side (e.g. parser class name, to specify the rule name instead of the rule class type).

And for changes to settings which don't require the debuggee side, we can implement INPC on the settings object itself for those settings and listen for those changes and/or use two-way databinding from WPF.

from antlr4parsetreevisualizer.

Some settings require a round-trip to the debuggee side (parser class). Others do not (maximum window height/width).

Settings which require a round-trip need to be checked in the ShouldTriggerReload property. Closing the popup checks this property, and if it returns true, the config is sent to the debuggee side again.

Settings which don't require a round-trip should simply trigger an NPC event.

from antlr4parsetreevisualizer.

The underlying work is done; only the specific settings described here need to be implemented.

But I'm leaving this pinned, because we haven't tested the global settings yet.

from antlr4parsetreevisualizer.

I'm closing this; none of the settings here really justify keeping it open.

from antlr4parsetreevisualizer.