Giter VIP home page Giter VIP logo

Comments (10)

ejuarezg avatar ejuarezg commented on June 19, 2024 1

Interesting.. If I ever find the culprit of this bug, I'll let you know. For all I know, the cause could be some other zsh setting/option that I use in my main config. Thanks for your help!

Cheers

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

Could you post some screenshots?

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

@ejuarezg I think I haven't forget to reset some style, and it's not needs %b because I have really reset all style prefixed each prompt parts, also it's prefix to the user input area;

image

image

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

@ejuarezg Maybe you are manually install and used it without oh-my-zsh (like the steps in docs),

actually it's a bug that sgr_reset will invalid due to not load zsh/colors module (zmodload zsh/colors),

and I fixed it in v2.2.1, would you upgrade the theme?

from jovial.

ejuarezg avatar ejuarezg commented on June 19, 2024

Yes, I did install this manually. However, I'm still able to reproduce it in the new version. See the inconsistency in the lines where I use rm and echo in the attached screenshot.
image

This is the zsh config I'm using to load and configure jovial:

setopt prompt_subst
source "$ZSH_PLUGINS_PATH/jovial/jovial.zsh-theme"
source "$ZSH_PLUGINS_PATH/jovial/jovial.plugin.zsh"
JOVIAL_SYMBOL[arrow.git-clean]='(^‿‿^)'
JOVIAL_SYMBOL[arrow.git-dirty]='(-__-)'

ZSH_PLUGINS_PATH is just a path variable pointing to my plugins location.

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

@ejuarezg Could you run this print commands below and take a screenshot to reply?

print -P "%B xxxx  xxxx"
print -P "%B xxxx %b xxxx"
print -P "%B xxxx ${sgr_reset} xxxx"

Additionally, note that the syntax highlight of user input area is not provide by jovial, including bold like rm README.md in your screenshot shown;
It provides by zsh-syntax-highlighting plugin most of the time, so you can disable it and try to reproduce again.

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

@ejuarezg Is that still able to reproduce the inconsistency bold when you disable other plugins?

from jovial.

ejuarezg avatar ejuarezg commented on June 19, 2024

Ok, I went ahead and nuked my entire zsh config and just loaded the jovial theme. Here's what it looks like after running the commands:
image

I guess this rules out your zsh theme causing the inconsistency. It may be due to zsh-syntax-highlighting or zsh-history-substring-search plugin that I use.

It is weird though that adding %b to path.suffix seems to fix the problem.

Edit: I deleted a previous post due to error where I used my jovial fork instead of your repo.

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

@ejuarezg Fine, thanks for use and feedback 😄 and path.suffix in JOVIAL_AFFIXES is also design for customization, so you may not need fork this repo or change source file, just set config to override in your .zshrc will be okay;

# ~/.zshrc

JOVIAL_AFFIXES[path.suffix]="%b"

see more in https://github.com/zthxxx/jovial#affixes

from jovial.

zthxxx avatar zthxxx commented on June 19, 2024

BTW, I have also used zsh-syntax-highlighting and zsh-autosuggestions, but cannot reproduce the bug after v2.2.1.

from jovial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.