Comments (6)
ToucheSir
commented on June 7, 2024
It's been pointed out to me that the relevant logic lives in
Lines 62 to 64 in bcd29a1
from zulip-archive.
timabbott
commented on June 7, 2024
I'm not sure -- I think @showell or @rht might have thought more about the URL-encoding for zulip-archive than I have?
I think part of the complexity here is that this wants to agree with the URL-encoding methods used by the Zulip webapp.
from zulip-archive.
refeed
commented on June 7, 2024
I think this can be closed as we don't use jekyll anymore.
from zulip-archive.
alya
commented on June 7, 2024
I think this can be closed as we don't use jekyll anymore.
@rht perhaps you could close this issue if you agree? Thanks!
from zulip-archive.
rht
commented on June 7, 2024
I don't have admin right to close the issue, but I agree with @refeed. The issue is fixed by 78da21b.
from zulip-archive.
rht
commented on June 7, 2024
Though it's because of the URL encoding, not specifically Jekyll.
from zulip-archive.
Related Issues (20)
- Update zulip2.png -> zulip.png
- Apply Black to the entire repo HOT 2
- action.yml: Allow user to specify custom `page_head_html` and `page_footer_html`.
- Showing images HOT 1
- Non-ASCII topics render with mojibake in a stream’s topic list HOT 3
- Automatically generate sitemap.xml after the archive is built. HOT 2
- How can I archive private streams? HOT 2
- Fail to archive due to Python version too low HOT 1
- Update docker image of Zulip action to an image that comes with a newer Python version
- Allow use of GITHUB_TOKEN when running in GH Actions HOT 4
- Pages API is no longer in preview
- Custom header/footer fails on topic pages?
- Add support for targeting specifically streams with the `is_web_public` flag
- Action fails due to fatal "unsafe repository" error HOT 3
- Link to web-public streams view HOT 2
- Print the executed commands in entrypoint.sh HOT 1
- Run the tests in the GitHub actions HOT 1
- Add link to open code block in playground HOT 1
- Archive does not include emoji reactions
- instructions.md: dependency list is now incorrect HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zulip-archive.