Giter VIP home page Giter VIP logo

Comments (19)

Zulko avatar Zulko commented on August 28, 2024

I touched these files recently... when did you download the module ? Are you using Python 2 or Python 3 ?

from moviepy.

stewpend0us avatar stewpend0us commented on August 28, 2024

I downloaded maybe last week? Fairly recent. I'd love to use python 3 but the last time I looked it wasn't supported....so I'm using 2.7

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Ok, so I didn't know that this bug existed in python 2.7, but people of
the Python3 world complained about the hanging. The cause seems to be
that the default buffer in subprocess is very small in Python3 (and
apparently not big enough in python2.7). So yesterday I changed these
files to force a bigger buffer.

If you could update and give it a try, that would be great ! Also it
should not hang any more, you should get a proper error is something
goes wrong.

Le 15/02/2014 21:55, stewpend0us a รฉcrit :

I downloaded maybe last week? Fairly recent. I'd love to use python 3
but the last time I looked it wasn't supported....so I'm using 2.7

โ€”
Reply to this email directly or view it on GitHub
#13 (comment).

from moviepy.

stewpend0us avatar stewpend0us commented on August 28, 2024

I installed using pip btw..and just tried an upgrade that told me it's up to date. Maybe I'm using an older version then I realized if whatever pip gives me isn't the latest. I'll download the source and give it a try...

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Did it work ?

from moviepy.

stewpend0us avatar stewpend0us commented on August 28, 2024

Haven't had a chance yet...I will test it out and let you know.

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Cool. there is no hurry ;)

Le 19/02/2014 15:14, stewpend0us a รฉcrit :

Haven't had a chance yet...I will test it out and let you know.

โ€”
Reply to this email directly or view it on GitHub
#13 (comment).

from moviepy.

stewpend0us avatar stewpend0us commented on August 28, 2024

Alright pretty sure i'm running version 2.1.4.05 (if there's a way to do moviepy.version or something I can confirm that but it's definitely not the same code that I was running before.)

Same issue. Hangs at frame 166.

I didn't see any reason not to close stdin in ffmpeg_reader or stdout and stderr in ffmpeg_writer so I tried that and it still hung.

When I add stderr to the list on ffmpeg_reader it works again....

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

I have the same issue after 6 minutes of every rendering.
But adding "self.proc.stderr.close()" to line 72 in the ffmpeg_writer.py fixes it for me. Additionally adding "self.proc.stdin.close()" is a bad idea.
My python version in use is 2.7.3, the moviepy version is the current from pip. Right after you fixed the rotation bug. ๐Ÿ‘

I hope this helps fixing the problem for anyone else.

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Thanks for the feedback. I think it's pretty clear now that I have no idea what is going on. It seems to always work on my computer but whatever I do its buggy on other distributions. Could you please make a commit with the correction ? Thanks in advance !

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

I changed this in the last versions. I think closing the error pipe was not the best way to proceed, so now the error pipe is redirected towards devnull or towards some file . It's all a little technical but I expect that this should not cause any problem.

When you have time / If you are still interested , can you try the latest version on Github and tell me if it works ? I yes I can close that issue.

Thanks in advance !

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

HI there, sorry for the very late reply. I totally forgot to write back.

I tested your patch with my project twice, and id crashed both times as before. The chances are great that its OS dependent. As long as people find this thread, they should be able to work around this problem. Another workaround would be, if you add a switch to the class to deactivate it.

Have a nice easter, oxivanisher

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Ok, thanks. Just to be sure: did you try with a recent version of MoviePy, or was it just at the time ? What is your OS ?

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

I checked the sourcecode (pip) and it was the "corrent" one at this time. But i will gladly test it again and make sure. I use Debian Wheezy x64 and a downloaded version of ffmpeg.

I will test it today or tomorrow and leave a comment here.

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

It is looking good! ๐Ÿ‘ It is already rendering for 18 minutes and all the other times it crashed after 6 minutes. I will let it run for another 12 minutes to surely reach 30 minutes. I thing we would be safe after that. :D Very nice work.

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

I let it finish the run and it worked perfectly for over 70 minutes. I think its save to close this issue for good. ๐Ÿ‘

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

That's a relief, thanks for testing. For info, one of the things I have changed is that now the pipes for the output or the errors returned by FFMPEG are now redirected either towards a file or towards "DEVNULL" (which, if I understood well, is where you send the unwanted streams).

I am curious, your processes seem a little long, what is your frame writing rate (i.e. when you launch to_videofile, it should print something like "XXX iters/sec", what is XXX ?)

from moviepy.

oxivanisher avatar oxivanisher commented on August 28, 2024

It is around 25. I overlayed clips with Images (fade in, and then out again) over a FullHD Video recording with audio. The output file was rendered to 720p (it wanted to take 16+ hours). My system has 16GB RAM and a 8 Core CPU, but i played around with multithreading (added the option to the FFMPEG call) but it did not go faster. Its an Athlon "Don't know what exactly" with 3.4 GHz per core.
I think this was the limiting factor.

from moviepy.

Zulko avatar Zulko commented on August 28, 2024

Ok, everything fine then, I am closing this issue.

from moviepy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.