Comments (19)
@TetianaP Did you test this against master? I think this may have been fixed as I'm not able to reproduce it there. Can you try master as well? If its working I'll go ahead and cut a new release.
from tribute.
Reproduced on the latest version available through npm install - v2.3.1.
Is it different from master?
from tribute.
Yeah, master is more up to date than the latest release.
from tribute.
@TetianaP I've pushed up 2.3.2
. Let me know if that fixes your issue!
from tribute.
Checked on new version 2.3.2. The issue can still be reproduced.
from tribute.
Fixed in V3
from tribute.
@mrsweaters please reopen this issue.
It was tested on V3, and it is not fixed.
from tribute.
It appears that the default noMatchTemplate
is not working correctly. If i define a custom noMatchTemplate, the problem goes away. Working on a solution.
from tribute.
This should fix it! baf3df5
I've pushed this to master and it will get released in 3.0.1.
from tribute.
Thank you! Looks like it fixes the issue, unfortunately causing a few new ones:
- there is no way to hide menu when no item matches
- user can click on 'No Match!' item and logic for selecting item is triggered, causing errors
Could you please have a look on these? Or should i create a separate request?
from tribute.
I'll take a look at those couple of issues as well!
from tribute.
@TetianaP Fixed in https://github.com/zurb/tribute/releases/tag/3.1.0, thank you!
from tribute.
@mrsweaters
It seems like this fix is not working anymore.
https://zurb.github.io/tribute/example/
from tribute.
@benediktveith Should be working now. Give 3.5.3
a try.
from tribute.
@mrsweaters Looks good, thanks 👍
from tribute.
@mrsweaters It looks like the fix ain't working anymore? I tried on https://zurb.github.io/tribute/example/ but I got the same issue there.
In the example, when I type @j
I get the dropdown, then when I add a B (@jb
) I don't get any results and therefore no dropdown, then when I backspace to get back to @j
it doesn't show the dropdown.
I'm using version 3.7.3
in my project.
from tribute.
@ReneS1991 There were some changes around noMatchTemplate recently, this may have affected this behavior.
from tribute.
Okay, any idea if the behaviour will get fixed in the (near) future?
from tribute.
+1 ...
from tribute.
Related Issues (20)
- tributejs npm package version 5.1.3 is lastest, but not have loadingItemTemplate in options HOT 1
- Hi, why I can't use arrow key on my mention tooltip HOT 1
- Menu is offset incorrectly
- Cannot set cursor in front of the mention tag
- DOM-based XSS due to un-escaped special characters HOT 1
- Is it possible to add dropdown with heading?
- Removing items with backspace is not working when added by showMenuForCollection menu HOT 3
- Removing characters one by one with backspace then auto suggesting is not working HOT 1
- Instead of characters matches, is there words can match
- latest Typescript complile error
- Option to use DOM elements instead of HTML strings as templates
- Typescript 4.8.2 (Required by Angular 15) TributeOptions Type issue
- Update to stimulus-use debounce broke remote data load
- Error while clicking on scroll bar - chrome on mac
- Replacing words that contains space
- Performance issue and freezes
- When we can have a new version with the latest changes from master? HOT 2
- Tribute doesnot seem to work inside bootstrap modal.
- Disable the need a symbol to starts the lookup
- Issue with Deleting Mention via Programmatic Trigger in Tribute.js
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tribute.