Giter VIP home page Giter VIP logo

Comments (19)

mrsweaters avatar mrsweaters commented on May 26, 2024

@TetianaP Did you test this against master? I think this may have been fixed as I'm not able to reproduce it there. Can you try master as well? If its working I'll go ahead and cut a new release.

from tribute.

TetianaP avatar TetianaP commented on May 26, 2024

Reproduced on the latest version available through npm install - v2.3.1.
Is it different from master?

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

Yeah, master is more up to date than the latest release.

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

@TetianaP I've pushed up 2.3.2. Let me know if that fixes your issue!

from tribute.

TetianaP avatar TetianaP commented on May 26, 2024

Checked on new version 2.3.2. The issue can still be reproduced.

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

Fixed in V3

from tribute.

TetianaP avatar TetianaP commented on May 26, 2024

@mrsweaters please reopen this issue.
It was tested on V3, and it is not fixed.

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

It appears that the default noMatchTemplate is not working correctly. If i define a custom noMatchTemplate, the problem goes away. Working on a solution.

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

This should fix it! baf3df5

I've pushed this to master and it will get released in 3.0.1.

from tribute.

TetianaP avatar TetianaP commented on May 26, 2024

Thank you! Looks like it fixes the issue, unfortunately causing a few new ones:

  1. there is no way to hide menu when no item matches
  2. user can click on 'No Match!' item and logic for selecting item is triggered, causing errors

Could you please have a look on these? Or should i create a separate request?

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

I'll take a look at those couple of issues as well!

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

@TetianaP Fixed in https://github.com/zurb/tribute/releases/tag/3.1.0, thank you!

from tribute.

benediktveith avatar benediktveith commented on May 26, 2024

@mrsweaters
It seems like this fix is not working anymore.

https://zurb.github.io/tribute/example/

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

@benediktveith Should be working now. Give 3.5.3 a try.

from tribute.

benediktveith avatar benediktveith commented on May 26, 2024

@mrsweaters Looks good, thanks 👍

from tribute.

ReneS1991 avatar ReneS1991 commented on May 26, 2024

@mrsweaters It looks like the fix ain't working anymore? I tried on https://zurb.github.io/tribute/example/ but I got the same issue there.

In the example, when I type @j I get the dropdown, then when I add a B (@jb) I don't get any results and therefore no dropdown, then when I backspace to get back to @j it doesn't show the dropdown.

I'm using version 3.7.3 in my project.

from tribute.

mrsweaters avatar mrsweaters commented on May 26, 2024

@ReneS1991 There were some changes around noMatchTemplate recently, this may have affected this behavior.

from tribute.

ReneS1991 avatar ReneS1991 commented on May 26, 2024

Okay, any idea if the behaviour will get fixed in the (near) future?

from tribute.

sf-john-kim avatar sf-john-kim commented on May 26, 2024

+1 ...

from tribute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.